From owner-svn-src-head@freebsd.org Thu Jul 26 18:29:13 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0611810569F4; Thu, 26 Jul 2018 18:29:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98F7773418; Thu, 26 Jul 2018 18:29:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 41A9310AFD2; Thu, 26 Jul 2018 14:29:11 -0400 (EDT) Subject: Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build) To: Mark Millard References: <00D1127A-1F0E-4E0E-B86C-1C5AA5B2E085@yahoo.com> <7A845F2C-C994-4828-823D-33A97B7B6EB0@yahoo.com> <72081b02-cf23-82ec-32df-7f5793c35f57@FreeBSD.org> <003509F0-F2F4-4A43-82FE-3F6FC23D19D4@yahoo.com> <65b19cc4-eaf0-13ed-43e6-9f04a1f7f196@FreeBSD.org> <49BF6569-96A9-4104-BDE6-8BB94C0D9626@yahoo.com> <9251BE92-A8CE-45E3-B4BF-706E7219321A@yahoo.com> Cc: Dimitry Andric , Bryan Drewery , svn-src-head@freebsd.org, FreeBSD Current From: John Baldwin Message-ID: Date: Thu, 26 Jul 2018 11:29:10 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <9251BE92-A8CE-45E3-B4BF-706E7219321A@yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 26 Jul 2018 14:29:11 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 18:29:13 -0000 On 7/16/18 11:27 PM, Mark Millard wrote: > On 2018-Jul-1, at 6:34 AM, Mark Millard wrote: > >> My brain finally engaged for showing exactly what files are included >> for the gcc builds: the .meta files include that information explicitly >> (along with other files that are opened during the operation). >> >> amd64 is as I reported, just one header file from gcc: float.h . >> >> powerpc64 builds Lex/Lexer.cpp without defining __ALTIVEC__ and so >> is not including . Building without __ALTIVEC__ might >> be an error itself but would be a workaround for the altivec.h >> file name aliasing vs. search-path problem. >> >> . . . > > Going in a different direction, what of the unchanged Makefile.inc1 > code block: > > .if ${WANT_COMPILER_TYPE} == gcc || \ > (defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} == gcc) > # GCC requires -isystem and -L when using a cross-compiler. --sysroot > # won't set header path and -L is used to ensure the base library path > # is added before the port PREFIX library path. > CD2CFLAGS+= -isystem ${XDDESTDIR}/usr/include -L${XDDESTDIR}/usr/lib > # GCC requires -B to find /usr/lib/crti.o when using a cross-compiler > # combined with --sysroot. > CD2CFLAGS+= -B${XDDESTDIR}/usr/lib > # Force using libc++ for external GCC. > .if defined(X_COMPILER_TYPE) && \ > ${X_COMPILER_TYPE} == gcc && ${X_COMPILER_VERSION} >= 40800 > CD2CXXFLAGS+= -isystem ${XDDESTDIR}/usr/include/c++/v1 -std=c++11 \ > -nostdinc++ > .endif > .endif > > Why is that pair of -isystem uses that gives the old search order > okay? Or was the block just missed? (Similarly for other options > listed above.) Just missed. They should probably also be removed. > Note: Locally I've reverted the -r335782 changes in order for my use > of devel/*-gcc as cross compilers to work where they used to (hopefully: > still building), restoring the historical search order for the > directories for now. I finally got the approval 2 days ago to remove float.h from amd64-gcc so you shouldn't need this reverted anymore once the OFED thing is straightened out. -- John Baldwin