From owner-svn-src-all@FreeBSD.ORG Sat Aug 4 20:46:35 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8AF8E106564A; Sat, 4 Aug 2012 20:46:35 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 713858FC15; Sat, 4 Aug 2012 20:46:34 +0000 (UTC) Received: by lbbgk8 with SMTP id gk8so135283lbb.13 for ; Sat, 04 Aug 2012 13:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Hl3VXaZKtTH2BXNLgSnPOy1+4DrD3CAcLb3i7LX1EgU=; b=GsVsi2kOVhVxZwTmk6xxR0tYqDt+7nzKX6d8PyphIL37IonXNx8zna+QGEWl5XYr9+ lFmRLTN4qG8w0Bk15o0V6OZoZuA6XAvmQZi3jEE4DO06Im+vsZ/ioSvMkaaF6uKcN9gH Gi6UOLkUoaMJU6jX6pxwdFBESt/yuBIf4KaX1znWq43MyY7f3fMDZAWzQ+SbHJx25nsa dLwIz/MzLN8Rz0GzMYbYrMMjd0KwPyKRnUy50DmuD6VzFbD1xVJnFKQk2r0C4lWa+2Bh pJWz44oGkBgrBAUAcbhK6ItziQtqCpGEpKtbHwnls8DLgJRkeNHTLozPS9FZDoJcWz+q x+uA== MIME-Version: 1.0 Received: by 10.152.103.146 with SMTP id fw18mr5709950lab.30.1344113193034; Sat, 04 Aug 2012 13:46:33 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.27.65 with HTTP; Sat, 4 Aug 2012 13:46:32 -0700 (PDT) In-Reply-To: <201208041816.q74IGisk081197@svn.freebsd.org> References: <201208041816.q74IGisk081197@svn.freebsd.org> Date: Sat, 4 Aug 2012 21:46:32 +0100 X-Google-Sender-Auth: J0VXUQamVwSq__oCHuQmYj1r29c Message-ID: From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r239040 - in head/sys: fs/nfsclient fs/nwfs fs/smbfs nfsclient vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2012 20:46:35 -0000 On Sat, Aug 4, 2012 at 7:16 PM, Konstantin Belousov wrote: > Author: kib > Date: Sat Aug 4 18:16:43 2012 > New Revision: 239040 > URL: http://svn.freebsd.org/changeset/base/239040 > > Log: > Reduce code duplication and exposure of direct access to struct > vm_page oflags by providing helper function > vm_page_readahead_finish(), which handles completed reads for pages > with indexes other then the requested one, for VOP_GETPAGES(). The semantic of this new function is very questionable as I don't think we have any other function that accepts error as in-parameter (in particular if it does only a check). The error check should really belong to the consumers IMHO (even if duplicate). Attilio -- Peace can only be achieved by understanding - A. Einstein