From owner-freebsd-bugs@FreeBSD.ORG Wed Feb 1 06:30:15 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00D751065672 for ; Wed, 1 Feb 2012 06:30:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C8FB58FC15 for ; Wed, 1 Feb 2012 06:30:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q116UEts043388 for ; Wed, 1 Feb 2012 06:30:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q116UEm5043386; Wed, 1 Feb 2012 06:30:14 GMT (envelope-from gnats) Resent-Date: Wed, 1 Feb 2012 06:30:14 GMT Resent-Message-Id: <201202010630.q116UEm5043386@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yuri Pankov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 247AC1065674 for ; Wed, 1 Feb 2012 06:26:42 +0000 (UTC) (envelope-from yuri.pankov@gmail.com) Received: from sirius.xvoid.org (sirius.xvoid.org [IPv6:2001:470:28:4ba:20c:29ff:fe62:9a22]) by mx1.freebsd.org (Postfix) with ESMTP id BF9E18FC1A for ; Wed, 1 Feb 2012 06:26:41 +0000 (UTC) Received: from sirius.xvoid.org (yuri@sirius.xvoid.org [IPv6:::1]) by sirius.xvoid.org (8.14.5/8.14.5) with ESMTP id q116Qet1067372 for ; Wed, 1 Feb 2012 10:26:40 +0400 (MSK) (envelope-from yuri.pankov@gmail.com) Received: (from yuri@localhost) by sirius.xvoid.org (8.14.5/8.14.5/Submit) id q116QePw067371; Wed, 1 Feb 2012 10:26:40 +0400 (MSK) (envelope-from yuri.pankov@gmail.com) Message-Id: <201202010626.q116QePw067371@sirius.xvoid.org> Date: Wed, 1 Feb 2012 10:26:40 +0400 (MSK) From: Yuri Pankov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/164684: [kern][patch] Zero out dynamically allocated sbufs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yuri Pankov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2012 06:30:15 -0000 >Number: 164684 >Category: kern >Synopsis: [kern][patch] Zero out dynamically allocated sbufs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 01 06:30:14 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Yuri Pankov >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD sirius.xvoid.org 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r230537: Wed Jan 25 16:28:58 MSK 2012 yuri@sirius.xvoid.org:/usr/obj/data/src/freebsd/head/sys/GENERIC amd64 >Description: Filing this against kernel (as the source is in sys/kern), but got the problem itself using libsbuf - sbuf_newbuf() and sbuf_extend() don't zero out the malloc'ed memory, leading to issues when malloc debugging is enabled. >How-To-Repeat: #include #include #include int main(void) { struct sbuf *sb = sbuf_new_auto(); sbuf_cat(sb, "TEST TEST"); printf("s_buf=%s\n", sbuf_data(sb)); return(0); } $ MALLOC_OPTIONS=J ./sbuf s_buf=TEST TEST▒▒▒▒▒▒▒ $ MALLOC_OPTIONS=j ./sbuf s_buf=TEST TEST >Fix: --- sbuf-dynamic.diff begins here --- Index: sys/kern/subr_sbuf.c =================================================================== --- sys/kern/subr_sbuf.c (revision 230853) +++ sys/kern/subr_sbuf.c (working copy) @@ -159,6 +159,7 @@ newbuf = SBMALLOC(newsize); if (newbuf == NULL) return (-1); + memset(newbuf, 0, newsize); memcpy(newbuf, s->s_buf, s->s_size); if (SBUF_ISDYNAMIC(s)) SBFREE(s->s_buf); @@ -197,6 +198,7 @@ s->s_buf = SBMALLOC(s->s_size); if (s->s_buf == NULL) return (NULL); + memset(s->s_buf, 0, s->s_size); SBUF_SETFLAG(s, SBUF_DYNAMIC); return (s); } --- sbuf-dynamic.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: