From owner-svn-ports-head@freebsd.org Tue Apr 4 11:38:00 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7732D2DA13; Tue, 4 Apr 2017 11:38:00 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay102.isp.belgacom.be (mailrelay102.isp.belgacom.be [195.238.20.129]) (using TLSv1.2 with cipher RC4-SHA (128/128 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A447239F; Tue, 4 Apr 2017 11:37:59 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3A5PohER/V87Zv9f9uRHKM819IXTAuvvDOBiVQ1KB+?= =?us-ascii?q?0+IeIJqq85mqBkHD//Il1AaPBtSFraocwLOK+4nbGkU4qa6bt34DdJEeHzQksu?= =?us-ascii?q?4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPERvjKwV1?= =?us-ascii?q?Ov71GonPhMiryuy+4ZPebgFJiTanfb9+MBq6oRjeu8ILnYZsN6E9xwfTrHBVYe?= =?us-ascii?q?pW32RoJVySnxb4+Mi9+YNo/jpTtfw86cNOSL32cKskQ7NWCjQmKH0169bwtRbf?= =?us-ascii?q?VwuP52ATXXsQnxFVHgXK9hD6XpP2sivnqupw3TSRMMPqQbwoXzmp8rxmQwH0hi?= =?us-ascii?q?gZKzE58XnXis1ug6JdvBKhvAF0z4rNbI2IKPZyYqbRcNUHTmRDQ8lRTTRMDI28?= =?us-ascii?q?YYUREuQPPuRXr4fyqFQSohWzHhWsBPrzxjNUmnP6wa833uI8Gg/GxgwgGNcOvW?= =?us-ascii?q?zKotX0NqcSVf2+wbfPzTXEdPNZxzL955LOchA6vPqBWq5wccvTyUkrDA7Ljk+Q?= =?us-ascii?q?ppL7MD6Iy+oDvXKX7+16VeKgkmMqrRx6rDaoxscpkIbJh4QVx0jK9SVj3ok6O8?= =?us-ascii?q?a3SFVmbtK+F5tQrS6aO5NxQsM6X2FouSE6yrsduZKheSgKy5IqzAPcZfyfa4WF?= =?us-ascii?q?4RDuWPyQLDp4nn5pZbayihio/US+1+HxVc+520tQoCVfiNnDrHUN2gTW6siAV/?= =?us-ascii?q?Ry4F+s2S2K1wDP8uFEJl00lbbDJ54h3LEwkp0TvFzAHiDsnEX2jaqWeVs++uiv?= =?us-ascii?q?8ejnfrTmpp2YN4Nulg7+NaMumtehDuQ9KAcOWXOb9f671L358k31WLRKjvsona?= =?us-ascii?q?nFqJ3XJsYWqrS4DgJVyIov9hKyAjm83NgGgHUKL0pJeBedgIjoP1HOLur4DfC6?= =?us-ascii?q?g1m0jDdrxvLGPrn6D5XDNHjMjqnucq1m60FB0gYzyspf551MBrEbPP3zQlPxtM?= =?us-ascii?q?DfDhIhKAy03eDnBMxl1oMZQ2KPHrSZPLrSsVCW/O0gPvKBZIEPuDnjNfcq/OXu?= =?us-ascii?q?gmIjlV8aZ6mp0oMdaGqkEfR+P0WZfX3sj88aEWcUuAoyVfTqiFqYUT5PfHa+Rr?= =?us-ascii?q?gz5jU/CI+9A4fDXJ6ij6Ka0yegA5JafGdGCkqDEX3wbYWLR+8MaD6OIs9mijEE?= =?us-ascii?q?Tb+hS5U91RG1rQP1171nLu/R+i0ZqZLjyMZ65/fIlRwp+zx0FdqS3H+WQGFvg2?= =?us-ascii?q?wEXTg23LpwoUZl0FeMzbB4g+BEFdxU//5IXAA6NZnBwOxhEN/+RhzNc8yHSFa8?= =?us-ascii?q?XNqpHyo+TskszNMUZEZ9AdqihAjZ3yW2G78Vi6CLBJss/6LZxXfxO91wy3jc1K?= =?us-ascii?q?Y/kVYpWdBPOnC8iq547QjTCN2Br0LMsq+2daURwWbk7mGEyWbG6ERRTCZeS6jI?= =?us-ascii?q?d0szIEzMooKqyFnFSuqSCLYjeiBGztWPL6JMcZW9kVREQN/NItnTSVmd3WCqCk?= =?us-ascii?q?Dblfu3cIP2djBFj23mA08enlVWpC7eOA=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2B8BQCAhONY/9rBQVdcGgEBAQECAQEBA?= =?us-ascii?q?QgBAQEBFQEBAQECAQEBAQgBAQEBgylREHkSg2OKEnOPBYFhKQGHcI05gg4qhXg?= =?us-ascii?q?CgzlAGAEBAQEBAQEBAQEBaiiCMyIBgkABBSMzIxALDgYEAgIFIQICDxIYHgYTi?= =?us-ascii?q?XYDGQqtfYImhykNgyQBAQEBAQEBAwEBAQEBAQEhgQuKMoJRggODBoJfBZwyO4Z?= =?us-ascii?q?9hxuEK3eQUop4iH0fOIEFOy0Ihxw+NQGJGgEBAQ?= X-IPAS-Result: =?us-ascii?q?A2B8BQCAhONY/9rBQVdcGgEBAQECAQEBAQgBAQEBFQEBAQE?= =?us-ascii?q?CAQEBAQgBAQEBgylREHkSg2OKEnOPBYFhKQGHcI05gg4qhXgCgzlAGAEBAQEBA?= =?us-ascii?q?QEBAQEBaiiCMyIBgkABBSMzIxALDgYEAgIFIQICDxIYHgYTiXYDGQqtfYImhyk?= =?us-ascii?q?NgyQBAQEBAQEBAwEBAQEBAQEhgQuKMoJRggODBoJfBZwyO4Z9hxuEK3eQUop4i?= =?us-ascii?q?H0fOIEFOy0Ihxw+NQGJGgEBAQ?= Received: from 218.193-65-87.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([87.65.193.218]) by relay.skynet.be with ESMTP; 04 Apr 2017 13:36:46 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id v34BajV6019370; Tue, 4 Apr 2017 13:36:45 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Tue, 4 Apr 2017 13:36:45 +0200 From: Tijl Coosemans To: Mathieu Arnold Cc: Ben Woods , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437548 - head/print/hplip Message-ID: <20170404133645.24045446@kalimero.tijl.coosemans.org> In-Reply-To: <0b7881ec-c547-c69b-e420-78dde5ba6694@FreeBSD.org> References: <201704021034.v32AY77a032794@repo.freebsd.org> <0b7881ec-c547-c69b-e420-78dde5ba6694@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 11:38:00 -0000 On Tue, 4 Apr 2017 12:00:42 +0200 Mathieu Arnold wrote: > Le 02/04/2017 =C3=A0 12:34, Ben Woods a =C3=A9crit : >> Author: woodsb02 >> Date: Sun Apr 2 10:34:06 2017 >> New Revision: 437548 >> URL: https://svnweb.freebsd.org/changeset/ports/437548 >> >> Log: >> print/hplip: Improve option logic for X11, QT4, QT5 >> =20 >> If X11 option is disabled, the configure args should not enable >> QT4 or QT5, and their dependencies should not be added. >> =20 >> PR: 218213 >> Reported by: Tom Francis >> Reviewed by: Kevin Oberman >> >> Modified: >> head/print/hplip/Makefile >> >> Modified: head/print/hplip/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/print/hplip/Makefile Sun Apr 2 10:32:22 2017 (r437547) >> +++ head/print/hplip/Makefile Sun Apr 2 10:34:06 2017 (r437548) >> @@ -62,22 +62,34 @@ SCAN_CONFIGURE_ENABLE=3D scan-build >> X11_DESC=3D Graphical User Interface (Qt) >> X11_CONFIGURE_ENABLE=3D gui-build >> =20 >> -QT4_USES=3D pyqt:4 >> -QT4_USE=3D PYQT=3Dcore_run,dbussupport_run,gui_run >> -QT4_CONFIGURE_ENABLE=3D qt4 >> -QT4_IMPLIES=3D X11 >> - >> -QT5_USES=3D pyqt:5 >> -QT5_USE=3D PYQT=3Dcore_run,dbussupport_run,gui_run,widgets_run >> -QT5_CONFIGURE_ENABLE=3D qt5 >> -QT5_IMPLIES=3D X11 >> - >> XSANE_DESC=3D Install XSane for scanning (implies SCAN) >> XSANE_IMPLIES=3D SCAN >> XSANE_RUN_DEPENDS=3D xsane:graphics/xsane >> =20 >> DOCS_CONFIGURE_ENABLE=3D doc-build >> =20 >> +.include >> + >> +.if ${PORT_OPTIONS:MQT4} && ${PORT_OPTIONS:MX11} >> +USES+=3D pyqt:4 >> +USE_PYQT=3D core_run dbussupport_run gui_run >> +CONFIGURE_ARGS+=3D --enable-qt4 >> +.else >> +CONFIGURE_ARGS+=3D --disable-qt4 >> +.endif >> + >> +.if ${PORT_OPTIONS:MQT5} && ${PORT_OPTIONS:MX11} >> +USES+=3D pyqt:5 >> +USE_PYQT=3D core_run dbussupport_run gui_run widgets_run >> +CONFIGURE_ARGS+=3D --enable-qt5 >> +.else >> +CONFIGURE_ARGS+=3D --disable-qt5 >> +.endif >> + >> +.if ${PORT_OPTIONS:MX11} && ! ${PORT_OPTIONS:MQT4} && ! ${PORT_OPTIONS:= MQT5} >> +BROKEN=3D The X11 option requires one of the QT4 or QT5 options >> +.endif =20 >=20 > All those changes seem dubious, a simple QT4_IMPLIES=3DX11 and > QT5_IMPLIES=3DX11 would have been enough to express all of this. >=20 > Also, it seems X11 is not really an option, as it cannot be used alone, > maybe it should be folded into the QT4 and QT5 options. For print servers it's nice to disable X11 via make.conf and not have Qt or other x11 consumers pulled in. Maybe the port can switch to Qt5 without a Qt4 option. I would have waited for Plasma5 to hit the ports tree before making Qt5 the default though. Why force people to install Qt5 if there's no need for it? And do Qt5 apps use the right theme under KDE4?