From owner-freebsd-net Tue Nov 27 12: 2:38 2001 Delivered-To: freebsd-net@freebsd.org Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 1131E37B417; Tue, 27 Nov 2001 12:02:05 -0800 (PST) Received: (from rizzo@localhost) by iguana.aciri.org (8.11.3/8.11.1) id fARJvuj01234; Tue, 27 Nov 2001 11:57:56 -0800 (PST) (envelope-from rizzo) Date: Tue, 27 Nov 2001 11:57:56 -0800 From: Luigi Rizzo To: "Andrew R. Reiter" Cc: "Bruce A. Mah" , freebsd-net@FreeBSD.ORG Subject: Re: RFC: MFC M_ZERO usage for bpf.c Message-ID: <20011127115755.A1151@iguana.aciri.org> References: <200111271947.fARJlaq00597@nimitz.packetdesign.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tue, Nov 27, 2001 at 02:52:49PM -0500, Andrew R. Reiter wrote: > > Just as a note, I decided against MFC'ing this and similar changes because > I didn't feel it was necesary for -STABLE to have this "fix." why not ? code is more compact (and cache friendly) and readable, diffs from HEAD are reduced, no functional changes... I see only good things in these MFCs. While we are on the topic, I would also love to see more consistency in the use of macros vs. inline functions. E.g. below we have MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK | M_ZERO); and bp = (struct bpf_if *)malloc(sizeof(*bp), M_BPF, M_DONTWAIT | M_ZERO); and the same occurs elsewhere for free() and FREE(). This is confusing because it leads you into thinking that they are two different things while they are not. cheers luigi > On Tue, 27 Nov 2001, Bruce A. Mah wrote: > > :Hi-- > : > :I've been reading through src/sys/net/bpf.c, and I noticed that the > :changes to make it use M_ZERO haven't been MFC-ed to RELENG_4 yet. Any > :objection if I do this? (Nothing broke in my quick testing.) > : > :Thanks, > : > :Bruce. > : > :Index: bpf.c > :=================================================================== > :RCS file: /usr/ncvs/src/sys/net/bpf.c,v > :retrieving revision 1.59.2.6 > :diff -u -r1.59.2.6 bpf.c > :--- bpf.c 20 Sep 2001 14:31:33 -0000 1.59.2.6 > :+++ bpf.c 27 Nov 2001 18:49:45 -0000 > :@@ -358,8 +358,7 @@ > : if (d) > : return (EBUSY); > : make_dev(&bpf_cdevsw, minor(dev), 0, 0, 0600, "bpf%d", lminor(dev)); > :- MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK); > :- bzero(d, sizeof(*d)); > :+ MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK | M_ZERO); > : dev->si_drv1 = d; > : d->bd_bufsize = bpf_bufsize; > : d->bd_sig = SIGIO; > :@@ -1285,11 +1284,10 @@ > : u_int dlt, hdrlen; > : { > : struct bpf_if *bp; > :- bp = (struct bpf_if *)malloc(sizeof(*bp), M_BPF, M_DONTWAIT); > :+ bp = (struct bpf_if *)malloc(sizeof(*bp), M_BPF, M_DONTWAIT | M_ZERO); > : if (bp == 0) > : panic("bpfattach"); > : > :- bp->bif_dlist = 0; > : bp->bif_ifp = ifp; > : bp->bif_dlt = dlt; > : > : > : > : > > -- > Andrew R. Reiter > arr@watson.org > arr@FreeBSD.org > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message