From nobody Fri Nov 3 21:08:21 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SMYHp25hVz50NZW; Fri, 3 Nov 2023 21:08:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SMYHp1c4cz3MlW; Fri, 3 Nov 2023 21:08:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699045702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=icgdBg7Mkb5TAkI1GndoqFjRI6/ANLCCc+tXY8SVkIo=; b=E0tcBEuT+vEkzg/+F0hWyA5vYASM8WiNndMSfKVcJVRlXh2/cnzhPeONQ26qsTJyDKWeiu 1KRqfOeUmf88NYDWUdqgZ4stJfWaJsc0NLRoZoYLBzVQNu4mOiadDbUjVaC8rCedvds+ym ocoyNyBG3NaUePy2299xBmSMM063metEgDG1e0UWin5zXGBAqHst6/uW9tPNcZkvIl3vpo 7kz4Bt9wuFtzJOTXU1aXh5oDvnIZRrRmRXuEfnlv1YnRLhZxwvOMpfL4sneTcAoretZZ0u JwN5bjx1MiH495SycBMw164Tv30T2QxAVqhveyl5vM9IeD12e3WQTffywCPdtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699045702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=icgdBg7Mkb5TAkI1GndoqFjRI6/ANLCCc+tXY8SVkIo=; b=c32Ft+5fIeJzlNSofBjS4uNMZjoc6G7GI1hs9aI1Ltj6QUHiykm4cEjlMBEAxyDThBBMb8 wMd5lO4ZUYqFS6L+p7ehq1uBnz5bG6VCIGiZ+8Yif79wZVoA0QNgXbaE+LlvuukocAhndn amd8DHy/HmYZ+8Brpl/a7YEWFf6LtZLpyVjpewaYDSVSNqc8gvaRLj/gB58h67DIDAs8nW TeOJk/ExjWsqO6rRYhf9OK2/TOKYHoaJFUp9YiMPoTGXlXXjjxPiMeyH9AAT/t9RQZwIXM DajaweMgNgEBLrwZkzSD0qLVvnFbjkOT7Jcm3PyzXgq0LXSIGa3V5CFDlWTaEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699045702; a=rsa-sha256; cv=none; b=MYOwZY+kVZCYaZ+kYbxQkgVtKSWHbbW/E0gDvQT/+C+rLK8bA5sJ/w4/kZxN5u32ugJZx4 3dRHVKbCONLrfFz+hUD1toG/LRxRcxR40ANRBh4kSLX7bK08fSALSHC0s1EjhncAk6NGw0 mhWhGsxli/qI+dOipkHwwoECEPDPqhjsSgmkBLMsmdWadYaasd6Lc/wPva8C0CVqOeN5Jg KpEk8xqCPn/gra9UhI3Db/8eE0pnLEY99vIoSBCQ5ai7rps74wXz1ZYCcm137MtAr6tJdI a6Abrz20wrBEjAN027d5a4GV2yu79jgEhIkJ44c3rBQ488LmXHksQK98hUCwqg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SMYHp0ggBzWLr; Fri, 3 Nov 2023 21:08:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3A3L8LkE081080; Fri, 3 Nov 2023 21:08:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3A3L8LDm081077; Fri, 3 Nov 2023 21:08:21 GMT (envelope-from git) Date: Fri, 3 Nov 2023 21:08:21 GMT Message-Id: <202311032108.3A3L8LDm081077@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 45c27ad5241f - main - LinuxKPI: 802.11: error on state transition failure List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 45c27ad5241f5491234afd0b47d13b8005fdb4de Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=45c27ad5241f5491234afd0b47d13b8005fdb4de commit 45c27ad5241f5491234afd0b47d13b8005fdb4de Author: Bjoern A. Zeeb AuthorDate: 2023-10-25 22:29:35 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-11-03 21:08:03 +0000 LinuxKPI: 802.11: error on state transition failure The state transition failures we were seeing in the early days are solved. If we now experience one stop processing before passing over to net80211 (sta_newstate()) and before updating iv_state on the vap. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: cc Differential Revision: https://reviews.freebsd.org/D42423 --- sys/compat/linuxkpi/common/src/linux_80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index e8fb5b4914a6..3da91fa3e0b7 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2137,12 +2137,11 @@ lkpi_iv_newstate(struct ieee80211vap *vap, enum ieee80211_state nstate, int arg) } if (error != 0) { - /* XXX-BZ currently expected so ignore. */ ic_printf(vap->iv_ic, "%s: error %d during state transition " "%d (%s) -> %d (%s)\n", __func__, error, ostate, ieee80211_state_name[ostate], nstate, ieee80211_state_name[nstate]); - /* return (error); */ + return (error); } #ifdef LINUXKPI_DEBUG_80211