Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Nov 2023 21:08:21 GMT
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 45c27ad5241f - main - LinuxKPI: 802.11: error on state transition failure
Message-ID:  <202311032108.3A3L8LDm081077@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=45c27ad5241f5491234afd0b47d13b8005fdb4de

commit 45c27ad5241f5491234afd0b47d13b8005fdb4de
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2023-10-25 22:29:35 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2023-11-03 21:08:03 +0000

    LinuxKPI: 802.11: error on state transition failure
    
    The state transition failures we were seeing in the early days are
    solved.  If we now experience one stop processing before passing
    over to net80211 (sta_newstate()) and before updating iv_state on
    the vap.
    
    Sponsored by:   The FreeBSD Foundation
    MFC after:      3 days
    Reviewed by:    cc
    Differential Revision: https://reviews.freebsd.org/D42423
---
 sys/compat/linuxkpi/common/src/linux_80211.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c
index e8fb5b4914a6..3da91fa3e0b7 100644
--- a/sys/compat/linuxkpi/common/src/linux_80211.c
+++ b/sys/compat/linuxkpi/common/src/linux_80211.c
@@ -2137,12 +2137,11 @@ lkpi_iv_newstate(struct ieee80211vap *vap, enum ieee80211_state nstate, int arg)
 	}
 
 	if (error != 0) {
-		/* XXX-BZ currently expected so ignore. */
 		ic_printf(vap->iv_ic, "%s: error %d during state transition "
 		    "%d (%s) -> %d (%s)\n", __func__, error,
 		    ostate, ieee80211_state_name[ostate],
 		    nstate, ieee80211_state_name[nstate]);
-		/* return (error); */
+		return (error);
 	}
 
 #ifdef LINUXKPI_DEBUG_80211



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202311032108.3A3L8LDm081077>