From owner-freebsd-current@FreeBSD.ORG Fri Apr 18 09:28:23 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D199637B401 for ; Fri, 18 Apr 2003 09:28:22 -0700 (PDT) Received: from sccrmhc01.attbi.com (sccrmhc01.attbi.com [204.127.202.61]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B95543FE0 for ; Fri, 18 Apr 2003 09:28:22 -0700 (PDT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc01.attbi.com (sccrmhc01) with ESMTP id <2003041816282000100a3pbbe>; Fri, 18 Apr 2003 16:28:21 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id JAA62568; Fri, 18 Apr 2003 09:28:19 -0700 (PDT) Date: Fri, 18 Apr 2003 09:28:16 -0700 (PDT) From: Julian Elischer To: Bruce Evans In-Reply-To: <20030418224018.Y12417@gamplex.bde.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Jeff Roberson cc: FreeBSD current users Subject: Re: some small patches X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2003 16:28:24 -0000 On Fri, 18 Apr 2003, Bruce Evans wrote: > On Thu, 17 Apr 2003, Julian Elischer wrote: > > > On Thu, 17 Apr 2003, Jeff Roberson wrote: > > > > > I object to the sched_clock() change. We've discussed this on threads@ > > > > Yes and the clock code doesn't need to know about KSEs and it is of > > ABSOLUTLY NO difference to the sched_clock() function if it derives the > > thread from the KSE or derives the KSE from the thread. > > I mostly agree, but your argument would be better if statclock() didn't > need to know about the KSE to determine the niceness. The niceness It doesn't, the patch also gets the niceness without going via the KSE. the current code says: ke->ke_ksegrp->kg_nice the patched code says: td->td_ksegrp->kg_nice which gives the same thing. > statistic is rotting anyway. It only covers one type of special > scheduling. Statistics utilites generally are mostly missing support for > the following complications: > - rtprio/idprio scheduling > - POSIX scheduling > - KSE > - alternative schedulers yep. That last one can be fixed easier in a running kernel, but becomes very hard to fix with coredumps. (coredumps can't call methods). > > Bruce >