From owner-freebsd-current@FreeBSD.ORG Sat Jan 24 17:51:43 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D86431065670 for ; Sat, 24 Jan 2009 17:51:43 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (mailrelay.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id 5EFB58FC08 for ; Sat, 24 Jan 2009 17:51:43 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 280F8A0726; Sat, 24 Jan 2009 18:51:42 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 1C957A0724; Sat, 24 Jan 2009 18:51:42 +0100 (CET) Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id 09A43A0712; Sat, 24 Jan 2009 18:51:42 +0100 (CET) Received: from wep4035 ([132.187.37.35]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.0.2HF443) with ESMTP id 2009012418514150-20605 ; Sat, 24 Jan 2009 18:51:41 +0100 Received: by wep4035 (sSMTP sendmail emulation); Sat, 24 Jan 2009 18:51:41 +0100 From: "Alexey Shuvaev" Date: Sat, 24 Jan 2009 18:51:41 +0100 To: John Baldwin Message-ID: <20090124175141.GA1583@wep4035.physik.uni-wuerzburg.de> References: <200811191503.02192.jhb@freebsd.org> <4937EC6D.7050703@FreeBSD.org> <200901211536.08297.jhb@freebsd.org> MIME-Version: 1.0 In-Reply-To: <200901211536.08297.jhb@freebsd.org> Organization: Universitaet Wuerzburg User-Agent: Mutt/1.5.18 (2008-05-17) X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.0.2HF443 | November 25, 2008) at 01/24/2009 06:51:41 PM, Serialize by Router on domino1/uni-wuerzburg(Release 8.0.2HF443 | November 25, 2008) at 01/24/2009 06:51:41 PM, Serialize complete at 01/24/2009 06:51:41 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Cc: current@freebsd.org Subject: Re: ppc hints ignored? Was: [PATCH] ppbus/ppc locking X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2009 17:51:44 -0000 John Baldwin wrote: > Please test! This is the last non-MPSAFE network driver at this point. > this patch adds locking for the ppbus(4)/ppc(4) devices and the various ppbus > child devices (lpt, vpo, lpbb, ppi, pps). The basic model is that a single > mutex in the ppc(4) driver protects the ppc0 hardware and is shared with the > various child drivers. Two drivers now have detach methods that did not have > them before (plip and ppi). I've done some simple testing on my laptop (able > to load the drivers and do some simple things w/o panic'ing or tripping > assertions), but I am not really able to test the peripheral drivers fully. > > http://www.FreeBSD.org/~jhb/patches/ppc_locking.patch > Hello! I have also got panic around PPC_ASSERT_LOCKED(ppc) in ppc.c:1983 (cvsup-ed at app. Sat Jan 24 16:30 UTC 2009) What I noticed is that having: hint.ppc.0.at="isa" hint.ppc.0.disabled="1" hint.ppc.0.irq="7" does not prevent ppc from attaching. Rebooted with old kernel: FreeBSD wep4035 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Wed Jan 14 22:02:23 CET 2009 root@wep4035:/usr/obj/usr/src/sys/NOUSB amd64 and it also attached ppc despite the line in device.hints. Looks like not a ppc fault. ??? Alexey.