From owner-cvs-all Fri Jun 9 0:29:22 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 117EB37C27A; Fri, 9 Jun 2000 00:29:13 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id RAA07045; Fri, 9 Jun 2000 17:29:03 +1000 Date: Fri, 9 Jun 2000 17:29:00 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: John-Mark Gurney Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/sys kqueue.2 In-Reply-To: <20000608151419.24215@hydrogen.funkthat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 8 Jun 2000, John-Mark Gurney wrote: > > > add missing sys/time.h for struct timespec def... > > > > This is bogus. forward-declares struct timespec so that > > is not a prerequisite for . only > > needs to be included when the complete type for struct timespec is needed. > > Even if kevent() is called, the complete type isn't needed unless the > > timeout arg is non-NULL and is constructed in the same file. Anyway, > > POSIX.1-1996 says that struct timespec is declared in . > > so, is the correct fix to take it out of to change it to time.h? Maybe. Unfortunately for my argument, there are examples of including sometimes-unnecessary headers in timeout.2 and printf.3. is needed for using only the varargs functions, and the includes and prototypes are arranged so that the include of is only before the prototypes that appear to need it. The include of in kqueue.2 is disordered. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message