From owner-freebsd-usb@FreeBSD.ORG Fri May 7 07:50:03 2010 Return-Path: Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CEBB11065672 for ; Fri, 7 May 2010 07:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id BE74F8FC1B for ; Fri, 7 May 2010 07:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o477o36G008574 for ; Fri, 7 May 2010 07:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o477o314008573; Fri, 7 May 2010 07:50:03 GMT (envelope-from gnats) Date: Fri, 7 May 2010 07:50:03 GMT Message-Id: <201005070750.o477o314008573@freefall.freebsd.org> To: freebsd-usb@FreeBSD.org From: Hans Petter Selasky Cc: Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Hans Petter Selasky List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2010 07:50:03 -0000 The following reply was made to PR usb/146367; it has been noted by GNATS. From: Hans Petter Selasky To: freebsd-usb@freebsd.org Cc: Alex Deiter , freebsd-gnats-submit@freebsd.org Subject: Re: usb/146367: [PATCH] Revision 205728: broken bluetooth mouse support Date: Fri, 7 May 2010 09:38:49 +0200 On Friday 07 May 2010 05:49:43 Alex Deiter wrote: > Alex Deiter > Hi, The first part of the patch is not correct. The ID byte should be included in the buffer or you need to extend the buffer. Note that the kernel version of hid_get_data() is different at this point. The second part of your patch is correct, and indicates a merge glitch, due to changing the signedness of the data type some time back. Can you try the following patch in kernel and user-space and see that it works for your BT-mouse and USB-mouse? http://p4web.freebsd.org/@@177882?ac=10 --HPS