Date: Mon, 16 Jan 2023 15:13:37 -0700 From: Adam Weinberger <adamw@adamw.org> To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org>, jaap@nlnetlabs.nl Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option Message-ID: <CAP7rwci4NT5N5dPbdqgVHYDaM8H%2BoydOv6x72JHKY4GdQk5Hzg@mail.gmail.com> In-Reply-To: <CAGwOe2aEY9ok_B-Tc2GeX8jDkXvjhrjNck7kLJ4pnbaWz1DMQw@mail.gmail.com> References: <202301161248.30GCmHnK091914@gitrepo.freebsd.org> <CAP7rwcgBQD3oQJRKyvjposA=WW1%2BJku7Xzv_mF2-rcwJy-eqdg@mail.gmail.com> <CAGwOe2aEY9ok_B-Tc2GeX8jDkXvjhrjNck7kLJ4pnbaWz1DMQw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000a1fdd05f268e629 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2023 at 2:12 PM Fernando Apestegu=C3=ADa <fernape@freebsd.o= rg> wrote: > > > El lun., 16 ene. 2023 19:50, Adam Weinberger <adamw@adamw.org> escribi=C3= =B3: > >> >> >> On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa <fernape@freebs= d.org> >> wrote: >> >>> The branch main has been updated by fernape: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322= 555f0afbb8383 >>> >>> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383 >>> Author: Fernando Apestegu=C3=ADa <fernape@FreeBSD.org> >>> AuthorDate: 2023-01-15 19:29:38 +0000 >>> Commit: Fernando Apestegu=C3=ADa <fernape@FreeBSD.org> >>> CommitDate: 2023-01-16 12:44:02 +0000 >>> >>> dns/unbound: add dynlib port option >>> >> >>> PR: 268942 >>> Reported by: me@rcm.sh >>> Approved by: jaap@NLnetLabs.nl (maintainer) >>> --- >>> dns/unbound/Makefile | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> >> Does this need a pkg-plist change? If the plist is the same with this >> option on and off, what is this option actually controlling? >> > > The dynlib option is to build that module into the same daemon: > > > https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dy= namic-library-module-options > Ohhhh, so it's about loading *third-party* modules as shared libs? (Looping in maintainer here) If the previous statement is correct, would you be okay with me updating DYNLIB_DESC to reflect that? As it's currently written it looks like turning it off would create a fully statically-linked sbin/unbound, which is not the case. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --0000000000000a1fdd05f268e629 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:arial,sans-serif"><br></div></div><br><div class=3D"gmail_quote"><= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 16, 2023 at 2:12 PM Fernan= do Apestegu=C3=ADa <<a href=3D"mailto:fernape@freebsd.org">fernape@freeb= sd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m= argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left= :1ex"><div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D= "ltr" class=3D"gmail_attr">El lun., 16 ene. 2023 19:50, Adam Weinberger <= ;<a href=3D"mailto:adamw@adamw.org" target=3D"_blank">adamw@adamw.org</a>&g= t; escribi=C3=B3:<br></div><blockquote class=3D"gmail_quote" style=3D"margi= n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex= "><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-family:arial,sans-se= rif"><br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class= =3D"gmail_attr">On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa &l= t;<a href=3D"mailto:fernape@freebsd.org" rel=3D"noreferrer" target=3D"_blan= k">fernape@freebsd.org</a>> wrote:<br></div><blockquote class=3D"gmail_q= uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2= 04);padding-left:1ex">The branch main has been updated by fernape:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa6711= 0ba6d2d1e322555f0afbb8383" rel=3D"noreferrer noreferrer" target=3D"_blank">= https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322555f= 0afbb8383</a><br> <br> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383<br> Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= ><br> AuthorDate: 2023-01-15 19:29:38 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= ><br> CommitDate: 2023-01-16 12:44:02 +0000<br> <br> =C2=A0 =C2=A0 dns/unbound: add dynlib port option <br></blockquote><blockqu= ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px= solid rgb(204,204,204);padding-left:1ex"> <br> =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0268942<br> =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 <a href=3D"mailto:me@rcm.sh" rel=3D= "noreferrer" target=3D"_blank">me@rcm.sh</a><br> =C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 jaap@NLnetLabs.nl (maintainer)<br> ---<br> =C2=A0dns/unbound/Makefile | 9 ++++++---<br> =C2=A01 file changed, 6 insertions(+), 3 deletions(-)<br> <br></blockquote><div><br></div><div style=3D"font-family:arial,sans-serif"= >Does this need a pkg-plist change? If the plist is the same with this opti= on on and off, what is this option actually controlling?</div></div></div><= /blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">The d= ynlib option is to build that module into the same daemon:</div><div dir=3D= "auto"><br></div><div dir=3D"auto"><a href=3D"https://unbound.docs.nlnetlab= s.nl/en/latest/manpages/unbound.conf.html#dynamic-library-module-options" t= arget=3D"_blank">https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbou= nd.conf.html#dynamic-library-module-options</a><br></div></div></blockquote= ><div><br></div></div><div style=3D"font-family:arial,sans-serif" class=3D"= gmail_default">Ohhhh, so it's about loading *third-party* modules as sh= ared libs?</div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_= default"><br></div><div style=3D"font-family:arial,sans-serif" class=3D"gma= il_default">(Looping in maintainer here) If the previous statement is corre= ct, would you be okay with me updating DYNLIB_DESC to reflect that? As it&#= 39;s currently written it looks like turning it off would create a fully st= atically-linked sbin/unbound, which is not the case.</div><div style=3D"fon= t-family:arial,sans-serif" class=3D"gmail_default"><br></div><div style=3D"= font-family:arial,sans-serif" class=3D"gmail_default"># Adam<br></div><br c= lear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir= =3D"ltr"><div><div dir=3D"ltr"><div>Adam Weinberger</div><div><a href=3D"ma= ilto:adamw@adamw.org" target=3D"_blank">adamw@adamw.org</a></div><div><a hr= ef=3D"https://www.adamw.org" target=3D"_blank">https://www.adamw.org</a></d= iv></div></div></div></div></div> --0000000000000a1fdd05f268e629--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwci4NT5N5dPbdqgVHYDaM8H%2BoydOv6x72JHKY4GdQk5Hzg>