From owner-cvs-src@FreeBSD.ORG  Sun Nov 16 16:04:28 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 671CA16A4CE; Sun, 16 Nov 2003 16:04:28 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7556843F85; Sun, 16 Nov 2003 16:04:24 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id LAA32472;
	Mon, 17 Nov 2003 11:04:20 +1100
Date: Mon, 17 Nov 2003 11:04:20 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "Brian F. Feldman" <green@FreeBSD.org>
In-Reply-To: <200311160503.hAG53j2t058858@green.bikeshed.org>
Message-ID: <20031117105121.I4193@gamplex.bde.org>
References: <200311160503.hAG53j2t058858@green.bikeshed.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Robert Watson <rwatson@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: John Baldwin <jhb@FreeBSD.org>
Subject: Re: cvs commit: src/sys/conf kern.post.mk kmod.mk 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2003 00:04:28 -0000

On Sun, 16 Nov 2003, Brian F. Feldman wrote:

> Bruce Evans <bde@zeta.org.au> wrote:
> > On Fri, 14 Nov 2003, Robert Watson wrote:
> >
> > > On Fri, 14 Nov 2003, John Baldwin wrote:
> > >
> > > > On 14-Nov-2003 Brian Feldman wrote:
> > > > > green       2003/11/14 08:04:11 PST
> > > > >
> > > > >   FreeBSD src repository
> > > > >
> > > > >   Modified files:
> > > > >     sys/conf             kern.post.mk kmod.mk
> > > > >   Log:
> > > > >   Include opt_global.h in the modules build, when building from a normal
> > > > >   kernel build.  This makes it possible for me not to get pissed off that
> > > > >   ...
> >
> > Ugh.
> >
> > > > WITNESS doesn't matter as all calls to it are done in the actual locking
> > > > code itself which does not lives in modules.  Modules always call the
> > > > locking functions and don't inline locking operations.
> >
> > WITNESS actually has non-broken support for modules.  Modules cannot depend
> > on options, since they must work for all kernels.
> >
> > Here is a fix to unbreak the rdtsc() call similarly.
>
> I dunno, Bruce; I don't really agree with you there.  Modules are installed,
> as they are built in the src/sys/arch/compile/KERNEL directories, into the
> same directories as the kernel.

That is another bug :-).  It mainly wastes space and time, and steals cycles
from development of portable modules.

> This implies they're matched with the
> kernel.  I think depending on options in those modules is totally, perfectly
> fine.

Agreed, this is required the support the bug.

Bruce