From owner-freebsd-current  Sat Feb  9 19: 8:13 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id B1B1437B402; Sat,  9 Feb 2002 19:08:09 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id OAA17741;
	Sun, 10 Feb 2002 14:08:05 +1100
Date: Sun, 10 Feb 2002 14:10:50 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: John Baldwin <jhb@FreeBSD.ORG>
Cc: Mikhail Teterin <mi@aldan.algebra.com>, <current@FreeBSD.ORG>
Subject: RE: panic: bdwrite: buffer is not busy
In-Reply-To: <XFMail.020209192018.jhb@FreeBSD.org>
Message-ID: <20020210140121.D6710-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Sat, 9 Feb 2002, John Baldwin wrote:

> On 09-Feb-02 Mikhail Teterin wrote:
> > While attempting to ``fdisk fd0.1440''. Or ``fdisk fd0''. Or
> > ``newfs_msdos fd0.1440'' with or without the floppy inside :-\
> > With todays or Jan 3rd kernel (my previous upgrade).
>
> Only use fdisk on hard disks.  Still it shouldn't panic.  The bdwrite is just
> extra garbage, the real panic is due to a NULL pointer dereference:

This is a well known bug in the device layer.  I reported it on 2001/12/26
and fixed it locally a little later.  See the thread in -current about
"panic during fdisk'ing a md(4) device" for patches.

> I'm guessing that devsw() is returning NULL here.  You could add a KASSERT() to
> this macro just before the call to d_strategy() along the lines of
>
>         KASSERT(devsw((bp)->bio_dev) != NULL, ("no devsw for bio"));    \

Right.  From my original bug report:

! "fdisk /dev/fd0" now causes a null pointer panic in readdisklabel().
! This is because fdioctl() attempts to construct a (slightly wrong)
! device using dkmodpart(), but dkmodpart() only constructs a half-baked
! device since it only calls makedev().  The device is missing a devsw
! so DEV_STRATEGY() in readdisklabel() panics on it.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message