From owner-freebsd-current@FreeBSD.ORG  Thu Jul 10 13:06:30 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7866837B408
	for <current@FreeBSD.ORG>; Thu, 10 Jul 2003 13:06:30 -0700 (PDT)
Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DD3DE43F3F
	for <current@FreeBSD.ORG>; Thu, 10 Jul 2003 13:06:27 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 418 invoked from network); 10 Jul 2003 20:06:27 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <current@FreeBSD.ORG>; 10 Jul 2003 20:06:27 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6AK6PGI002617;
	Thu, 10 Jul 2003 16:06:25 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030710160639.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <Pine.BSF.4.21.0307101228100.40558-100000@InterJet.elischer.org>
Date: Thu, 10 Jul 2003 16:06:39 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Julian Elischer <julian@elischer.org>
cc: FreeBSD current users <current@FreeBSD.ORG>
Subject: RE: SMP and setrunnable()- scheduler 4bsd
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jul 2003 20:06:31 -0000


On 10-Jul-2003 Julian Elischer wrote:
> BTW in cpu_idle()
> 
>#ifdef SMP
>         if (mp_grab_cpu_hlt())
>                 return;
>#endif
> 
> 
> whta gain is there in this returning.. it will anyhow if there is work
> to do, and sched_runnable is called either way..
> 
> couldn't it just be 
> 
>#ifdef SMP
>       mp_grab_cpu_hlt();
>#endif
> 
> ?

*shrug*, ps@ stuck that in there and I didn't really look too closely.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/