From owner-svn-src-all@freebsd.org Wed Oct 31 16:58:44 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE27C10DF1CC for ; Wed, 31 Oct 2018 16:58:44 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FCB47E252 for ; Wed, 31 Oct 2018 16:58:44 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wm1-x343.google.com with SMTP id s10-v6so15837641wmc.5 for ; Wed, 31 Oct 2018 09:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uz6QUnhIN18yPS79tto/HOMX8L8azH2RhPhAjo4M86I=; b=BQhZAguHqnMhqlbbPTz7EzldXeUkuTmP7HrDQygEQyhGk4nf0MZz89fZGs3GGM5WLH PvhIyG9jvLGEts0WA3dgnBLBrwMFV/08y9Fjv1ml6PJLfh5H20YILBmmyyxkz7VS6sym q5mQ7hiLw+1WtiAuaKocH8EVLPa86lscQw4VHIzD1qaeyHY0tw7NoZad4eIWfm80/JX6 q/dsHw0b5uE0wwz0jT3nCuB20YMnOlvXVuIRDN9GH+nIrqYMflmUoxtU1PgiqJb9lnN7 /JXSaiCapcO5tWeEvekFQYx0opB/KBKjVa9zhx8tIedkYVPfr/Fs0JNO695zaupZkmwC Q5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uz6QUnhIN18yPS79tto/HOMX8L8azH2RhPhAjo4M86I=; b=eVRONJlA4Nit/+WgJ/sQCwPg4lUyBJ7WmFkCZT5D9S2I4fyGcXop8K4QmPdCunQ62V zZUdJMP+93xBmkBbkYOzkiRoeKxV6OTgDOp9QRR7HL0dIo8GdM17ozfpKzLAvp63H4K+ O93o67+na3JndsnRf8xR60AiOGRxbivss6kH/mZ/VQ65E5pufzba1Ihs3MTVimZZbHO7 tlvxegqY3pd7mLv/IAa8XRRZNZuFpzyP4g5dOCTuyruKHYqLVwZNOfIuh7EwbhAARtGe xiH7DuffK92JkjlCvSDdebQ0VRvNzCBu5gJOvoglrQ522Rd+DW6tinpIKGfTrigK7GOk Tj5Q== X-Gm-Message-State: AGRZ1gIld2UN8T1igDecYrQWfo7UqdDZq3EmkFMfWsjP4iWSmkVJi+zg x+Uf0w+hB47ObB403FKuMVWoiA== X-Google-Smtp-Source: AJdET5cw7XhP2st5A3KtCM83FYhxaL4v8lU5GQKandQiKTfTeM8akyhcuuFS6ifTilGxO3J4xcKoRA== X-Received: by 2002:a1c:868e:: with SMTP id i136-v6mr3045736wmd.50.1541005122237; Wed, 31 Oct 2018 09:58:42 -0700 (PDT) Received: from mutt-hbsd (tor-exit-2.zbau.f3netze.de. [185.220.100.253]) by smtp.gmail.com with ESMTPSA id v19-v6sm13184858wmd.20.2018.10.31.09.58.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 09:58:41 -0700 (PDT) Date: Wed, 31 Oct 2018 12:58:10 -0400 From: Shawn Webb To: Ed Maste Cc: Marcelo Araujo , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339936 - head/sys/amd64/vmm/amd Message-ID: <20181031165810.oiiyz2omi45sqoxc@mutt-hbsd> References: <201810310127.w9V1RiFX025463@repo.freebsd.org> <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vp6sorfm3mxggr3h" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD mutt-hbsd 12.0-ALPHA7 FreeBSD 12.0-ALPHA7 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180622 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 16:58:45 -0000 --vp6sorfm3mxggr3h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 31, 2018 at 06:50:53AM -0400, Ed Maste wrote: > On Wed, 31 Oct 2018 at 10:07, Shawn Webb wro= te: > > > > Does this need a /* FALLTHROUGH */ comment to appease the Coverity > > Gods? >=20 > No, successive case statements without intervening bodies is a widely > used idiom well understood by all reasonable tools. Good catch. Thanks for the clarification! --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --vp6sorfm3mxggr3h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlvZ3x0ACgkQaoRlj1JF bu4UAA//RzYwi/G7TRHpwkls2ih8yz1qbF0fc9GDHJCpXGHYOh81xDNod2eLTnTE DqVliYAK7v1P64G/d0qgi4gUdtUEhuY8gitrA+0X20HRW4wXagKN2TQ9nEsf0xLp LAhErULKw4wlsAEWQoPbu0ihu1GpMM7w+98x45uuvsEEW6hwQvKLxnEUNXjuVVQ/ /Mj1kOeKNiYZSMoJ4jietuVs08xtN4IwUAF2sSL4FKrhMdOVObJIuXc/6E4gC6JY XtS7FjABkC/gJewZI/MH4NKqKa+c75PNWKGS20KGBmAadgG0cxj2mG2xMHvxrA8v Jl7P0IdwspxkU5DbvpBxzGzA+mTpE4aaOy5ZeTXlGv85cbk1BcAssqB/Q0g1unxC rcJf8QYbhYc1y4gLWQttmMT/N+38FdsiDrxDeGlxcbjHI8myjXlNn0xuv29kMvW8 fZgum8flQ9YSjwQPxRv4E3rlWVWjQN59tMtRjRDHIoF4UB9/xCxxmTUAQJcTxMLj CsoIfy/JWk3LBQpVxPBxFynuC91Q6WDyu/hTPBg4EeVgEmSbNWumSIrhk1nh5NSE Zs+y8w5kFymsvK/dI9LVdlwX//fGvYa9o+GRBFNAW1gkjZhSIA3Z+Oqo1DekurMK oeT6ODs07qqOyPCB7iYGytkq8gVYXPA+iODVgrnPKS5VfwnK8mY= =Fu7W -----END PGP SIGNATURE----- --vp6sorfm3mxggr3h--