From owner-freebsd-current Wed Jan 27 18:30:30 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA21384 for freebsd-current-outgoing; Wed, 27 Jan 1999 18:30:30 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA21371 for ; Wed, 27 Jan 1999 18:30:28 -0800 (PST) (envelope-from archie@whistle.com) Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id SAA25722; Wed, 27 Jan 1999 18:29:52 -0800 (PST) Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0) id xma025717; Wed, 27 Jan 99 18:29:33 -0800 Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id SAA20207; Wed, 27 Jan 1999 18:29:33 -0800 (PST) From: Archie Cobbs Message-Id: <199901280229.SAA20207@bubba.whistle.com> Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280222.VAA14212@khavrinen.lcs.mit.edu> from Garrett Wollman at "Jan 27, 99 09:22:43 pm" To: wollman@khavrinen.lcs.mit.edu (Garrett Wollman) Date: Wed, 27 Jan 1999 18:29:33 -0800 (PST) Cc: current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Garrett Wollman writes: > > Please do go ahead and update it.. the experts agree! > > I haven't seen any experts involved in this discussion yet. It's > probably after bedtime down there in oz. It was discussed before a couple of weeks ago, and I didn't hear anybody on the other side. I could be mistaken though. Anyway, if we're going to -Wall'ify the kernel (as we should) then we need to update sytle(9) to reflect that. In fact, style(9) should say: If at all possible, your code should compile without warnings when the gcc -Wall flag is given. As it stands now (and I QUOTE!) it says: Don't use parentheses unless they're required for precedence, or the statement is really confusing without them. a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1; That's ridiculous! If you're telling me that line is not 'really confusing' then.. hell, I don't know what. I guess I just strongly disagree. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message