Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Apr 2021 19:38:32 GMT
From:      Renato Botelho <garga@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: cbb52569dd15 - stable/12 - A few more cases where strcasecmp() is no longer required.
Message-ID:  <202104281938.13SJcWaZ064595@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by garga (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=cbb52569dd1589e5e397cdb35cd36d746e8c3900

commit cbb52569dd1589e5e397cdb35cd36d746e8c3900
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2018-11-27 11:22:19 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2021-04-28 19:31:22 +0000

    A few more cases where strcasecmp() is no longer required.
    
    MFC after:      1 week
    Approved by:    kp
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit ceedec4bce2161062ffcacf7f07e364c8cfe09bc)
---
 lib/libfetch/http.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c
index 85d624e2da35..7ba170b7c775 100644
--- a/lib/libfetch/http.c
+++ b/lib/libfetch/http.c
@@ -1408,7 +1408,7 @@ http_connect(struct url *URL, struct url *purl, const char *flags)
 		/* fetch_connect() has already set an error code */
 		return (NULL);
 	init_http_headerbuf(&headerbuf);
-	if (strcasecmp(URL->scheme, SCHEME_HTTPS) == 0 && purl) {
+	if (strcmp(URL->scheme, SCHEME_HTTPS) == 0 && purl) {
 		http_cmd(conn, "CONNECT %s:%d HTTP/1.1",
 		    URL->host, URL->port);
 		http_cmd(conn, "Host: %s:%d",
@@ -1436,7 +1436,7 @@ http_connect(struct url *URL, struct url *purl, const char *flags)
 			}
 		} while (h > hdr_end);
 	}
-	if (strcasecmp(URL->scheme, SCHEME_HTTPS) == 0 &&
+	if (strcmp(URL->scheme, SCHEME_HTTPS) == 0 &&
 	    fetch_ssl(conn, URL, verbose) == -1) {
 		/* grrr */
 		errno = EAUTH;
@@ -1473,7 +1473,7 @@ http_get_proxy(struct url * url, const char *flags)
 			strcpy(purl->scheme, SCHEME_HTTP);
 		if (!purl->port)
 			purl->port = fetch_default_proxy_port(purl->scheme);
-		if (strcasecmp(purl->scheme, SCHEME_HTTP) == 0)
+		if (strcmp(purl->scheme, SCHEME_HTTP) == 0)
 			return (purl);
 		fetchFreeURL(purl);
 	}
@@ -1617,7 +1617,7 @@ http_request_body(struct url *URL, const char *op, struct url_stat *us,
 		if (verbose)
 			fetch_info("requesting %s://%s%s",
 			    url->scheme, host, url->doc);
-		if (purl && strcasecmp(URL->scheme, SCHEME_HTTPS) != 0) {
+		if (purl && strcmp(URL->scheme, SCHEME_HTTPS) != 0) {
 			http_cmd(conn, "%s %s://%s%s HTTP/1.1",
 			    op, url->scheme, host, url->doc);
 		} else {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104281938.13SJcWaZ064595>