From owner-cvs-sys Sat May 10 05:01:07 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id FAA02972 for cvs-sys-outgoing; Sat, 10 May 1997 05:01:07 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA02944; Sat, 10 May 1997 05:00:31 -0700 (PDT) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA25259; Sat, 10 May 1997 05:00:03 -0700 (PDT) Date: Sat, 10 May 1997 05:00:03 -0700 (PDT) Message-Id: <199705101200.FAA25259@freefall.freebsd.org> To: CVS-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern kern_time.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/05/10 05:00:03 Modified: sys/kern kern_time.c Log: Fixes from Bruce: Serious: - An important timevalfix() in settime[ofday]() was lost. Not so serious: - There was a race initializing `delta' in the check for setting the time backwards. - The `#ifdef notyet' check for setting the time more than a day forwards was back to front. [[I deleted the code, it's useless because of iteration - Peter]] - The timespec was not checked for validity in clock_settime(). - The timespec was not fully checked for validity in nanotime(). The check in itimerfix() is too late, since the conversion from a timespec to a timeval may overflow. - A garbage timeval was checked in settimeofday() for the (uap->tv == NULL && uap->tzp != NULL) case. I added the broken check this some time ago. Cosmetic: - The "inadvertantly (sic) sleeping forever" test always failed. hzto() always returns >= 1. - The style wasn't very KNFish. (I only changed new code.) Submitted by: bde Revision Changes Path 1.26 +64 -59 src/sys/kern/kern_time.c