From owner-cvs-all  Tue Jan 21 10: 9:56 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9809937B401; Tue, 21 Jan 2003 10:09:55 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1B85043F3F; Tue, 21 Jan 2003 10:09:55 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from melange (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.5/8.12.1) with ESMTP id h0LI9snN074288
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Tue, 21 Jan 2003 10:09:54 -0800 (PST)?g
	(envelope-from sam@errno.com)œ
X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange
Message-ID: <04bf01c2c178$4cc3eca0$52557f42@errno.com>
From: "Sam Leffler" <sam@errno.com>
To: "Thomas Moestl" <tmm@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
References: <200301211708.h0LH8Mn5005942@repoman.freebsd.org>
Subject: Re: cvs commit: src/sys/sparc64/sparc64 iommu.c
Date: Tue, 21 Jan 2003 10:09:54 -0800
Organization: Errno Consulting
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4807.1700
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> tmm         2003/01/21 09:08:22 PST
>
>   Modified files:
>     sys/sparc64/sparc64  iommu.c
>   Log:
>   Fix iommu_dvmamap_sync(): it was still operating as if the BUS_DMASYNC_*
>   constants where flag bits (as in NetBSD), although they are
consecutively
>   numbered in FreeBSD. This would cause unnecessary flushing in the
>   BUS_DMASYNC_POSTWRITE case, but was otherwise mostly harmless.
>
>   Revision  Changes    Path
>   1.16      +13 -5     src/sys/sparc64/sparc64/iommu.c
>
http://cvsweb.FreeBSD.org/src/sys/sparc64/sparc64/iommu.c.diff?r1=1.15&r2=1.
16
>

Gack!  Do you see a good reason for this?  This seems like something that'll
cause really hard to find bugs when porting drivers (though one should
probably not use more than one flag per op).  I'd really like to see these
constants have the same value on all systems.

    Sam


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message