From owner-cvs-ports@FreeBSD.ORG Sat Jul 28 09:52:39 2007 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C4B616A419; Sat, 28 Jul 2007 09:52:39 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75]) by mx1.freebsd.org (Postfix) with ESMTP id 11DEE13C480; Sat, 28 Jul 2007 09:52:38 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1]) by svm.csie.ntu.edu.tw (8.14.1/8.14.1) with ESMTP id l6S9qbZf094711; Sat, 28 Jul 2007 17:52:37 +0800 (CST) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: (from rafan@localhost) by svm.csie.ntu.edu.tw (8.14.1/8.14.1/Submit) id l6S9qbHo078159; Sat, 28 Jul 2007 17:52:37 +0800 (CST) (envelope-from rafan) Date: Sat, 28 Jul 2007 17:52:37 +0800 From: Rong-En Fan To: Doug Barton Message-ID: <20070728095237.GS88047@svm.csie.ntu.edu.tw> References: <200707271159.l6RBxTwp090951@repoman.freebsd.org> <46AA65F6.2000204@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RnxXMyWEPIZsopkG" Content-Disposition: inline In-Reply-To: <46AA65F6.2000204@FreeBSD.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-ports@FreeBSD.org, Chris Cowart , cvs-all@FreeBSD.org, Rong-En Fan , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/net-snmp4 Makefile pkg-plist ports/net-mgmt/net-snmp4/files snmpd.in snmpd.sh.sample X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2007 09:52:39 -0000 --RnxXMyWEPIZsopkG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 27, 2007 at 02:39:02PM -0700, Doug Barton wrote: > Rong-En Fan wrote: > > rafan 2007-07-27 11:59:29 UTC > >=20 > > FreeBSD ports repository > >=20 > > Modified files: > > net-mgmt/net-snmp4 Makefile pkg-plist=20 > > Added files: > > net-mgmt/net-snmp4/files snmpd.in=20 > > Removed files: > > net-mgmt/net-snmp4/files snmpd.sh.sample=20 > > Log: > > - Convert to rc.d style script > > - Bump PORTREVISION > > =20 > > Note that I changed few places of the patch to match Porter's Handboo= k. > > =20 > > PR: ports/114952 http://www.FreeBSD.org/cgi/query-pr.cgi= ?pr=3D114952 > > Submitted by: Chris Cowart > > =20 > > Revision Changes Path > > 1.106 +2 -6 ports/net-mgmt/net-snmp4/Makefile > > 1.1 +26 -0 ports/net-mgmt/net-snmp4/files/snmpd.in (new) > > 1.2 +0 -20 ports/net-mgmt/net-snmp4/files/snmpd.sh.sample (= dead) > > 1.24 +0 -1 ports/net-mgmt/net-snmp4/pkg-plist > >=20 >=20 > This looks good overall. One question, it looks like this script is > starting a service, would it benefit from the shutdown KEYWORD? Not quite sure whether we should add it. Both net-mgmt/net-snmp and base's bsnmpd do not have this keyword. Keep this daemon running during shutdown process may not be a bad idea, i.e. you can still monitoring the target system. Regards, Rong-En Fan >=20 > Doug >=20 > --=20 >=20 > This .signature sanitized for your protection --RnxXMyWEPIZsopkG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGqxHl144QkYb9jGgRAmtFAJ9c+cjCHX9GrtTUNw5YvLptv8HhegCePgJO Jj3bekfwFRT6NxeB9e3CmKU= =eFKm -----END PGP SIGNATURE----- --RnxXMyWEPIZsopkG--