From owner-p4-projects@FreeBSD.ORG Fri Nov 30 19:40:14 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B846E16A418; Fri, 30 Nov 2007 19:40:14 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7CF1D16A41B for ; Fri, 30 Nov 2007 19:40:14 +0000 (UTC) (envelope-from kmacy@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 73B8B13C46B for ; Fri, 30 Nov 2007 19:40:14 +0000 (UTC) (envelope-from kmacy@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lAUJeExL073016 for ; Fri, 30 Nov 2007 19:40:14 GMT (envelope-from kmacy@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lAUJeEJ1073012 for perforce@freebsd.org; Fri, 30 Nov 2007 19:40:14 GMT (envelope-from kmacy@freebsd.org) Date: Fri, 30 Nov 2007 19:40:14 GMT Message-Id: <200711301940.lAUJeEJ1073012@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to kmacy@freebsd.org using -f From: Kip Macy To: Perforce Change Reviews Cc: Subject: PERFORCE change 129839 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2007 19:40:15 -0000 http://perforce.freebsd.org/chv.cgi?CH=129839 Change 129839 by kmacy@kmacy:storage:toestack on 2007/11/30 19:40:08 initialize adapter pointer in tdev make remove tid panic more informative Affected files ... .. //depot/projects/toestack/sys/dev/cxgb/cxgb_offload.c#20 edit Differences ... ==== //depot/projects/toestack/sys/dev/cxgb/cxgb_offload.c#20 (text+ko) ==== @@ -602,7 +602,9 @@ { struct tid_info *t = &(T3C_DATA (tdev))->tid_maps; - BUG_ON(tid >= t->ntids); + if (tid >= t->ntids) + panic("tid=%d >= t->ntids=%d", tid, t->ntids); + if (tdev->type == T3A) atomic_cmpset_ptr((uintptr_t *)&t->tid_tab[tid].ctx, (long)NULL, (long)ctx); else { @@ -1229,6 +1231,8 @@ if (!t) return (ENOMEM); + dev->adapter = adapter; + err = (EOPNOTSUPP); if (dev->ctl(dev, GET_TX_MAX_CHUNK, &t->tx_max_chunk) < 0 || dev->ctl(dev, GET_MAX_OUTSTANDING_WR, &t->max_wrs) < 0 ||