From owner-freebsd-ports-bugs@freebsd.org Fri Aug 2 03:15:19 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E491FA7C7D for ; Fri, 2 Aug 2019 03:15:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 460C2v5nRZz4XWn for ; Fri, 2 Aug 2019 03:15:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C4AB2A7C7C; Fri, 2 Aug 2019 03:15:19 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C33B1A7C7B for ; Fri, 2 Aug 2019 03:15:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 460C2v4c7xz4XWm for ; Fri, 2 Aug 2019 03:15:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8004424495 for ; Fri, 2 Aug 2019 03:15:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x723FJBq087021 for ; Fri, 2 Aug 2019 03:15:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x723FJIw087008 for ports-bugs@FreeBSD.org; Fri, 2 Aug 2019 03:15:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 239586] sysutils/atop: a function pointer was called with incorrect number of argument Date: Fri, 02 Aug 2019 03:15:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: msl0000023508@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Aug 2019 03:15:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239586 Bug ID: 239586 Summary: sysutils/atop: a function pointer was called with incorrect number of argument Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: msl0000023508@gmail.com CC: samm@os2.kiev.ua CC: samm@os2.kiev.ua Flags: maintainer-feedback?(samm@os2.kiev.ua) In source file atopsar.c, function 'reportlive', a pointer to function was called with 16 arguments: if ( !(rv =3D (pridef[i].priline)(ss, (struct tstat *)0, 0, numsecs, numsecs*hertz, hertz, osvers, osrel, ossub,=20 stampalways ? timebuf : " ", 0, 0, 0, 0, 0, 0) ) ) However the actual functions are expecting 17 arguments, for example: static int cpuline(struct sstat *ss, struct tstat *ts, struct tstat **ps, int nactproc, time_t deltasec, time_t deltatic, time_t hz, int osvers, int osrel, int ossub, char *tstamp, int ppres, int ntrun, int ntslpi, int ntslpu, int pexit, int pzomb= ie) In particular it misses argument 'struct tstat **ps'. This resulted in erroneous '(null)' printed from atopsar(1), or depending t= he pointer size and the compiler optimization, it could even crash due to accessing an invalid pointer in printf(3): an-i386-machine$ atopsar -c 2 an-i386-machine 12.0-RELEASE-p5 FreeBSD 12.0-RELEASE-p5 GENERIC i386=20 2019/08/02 -------------------------- analysis date: 2019/08/02 ----------------------= ---- 10:55:48 cpu %usr %nice %sys %irq %softirq %steal %guest %wait %idle _= cpu_ 10:55:50 all 0 0 0 0 0 0 0 0 399 (null) 0 0 0 0 0 0 0 0 0 100 (null) 1 0 0 0 0 0 0 0 0 100 (null) 2 0 0 0 0 0 0 0 0 100 (null) 3 0 0 0 0 0 0 0 0 100 ... an-amd64-machine$ atopsar -c 2 an-amd64-machine 13.0-CURRENT FreeBSD 13.0-CURRENT r350103 GENERIC amd64= =20 2019/08/02 -------------------------- analysis date: 2019/08/02 ----------------------= ---- 11:05:36 cpu %usr %nice %sys %irq %softirq %steal %guest %wait %idle _= cpu_ 11:05:38 all 0 0 0 0 0 0 0 0 600 Segmentation fault (core dumped) --=20 You are receiving this mail because: You are the assignee for the bug.=