From owner-svn-src-head@freebsd.org Thu Aug 9 23:40:56 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C4271076FA9 for ; Thu, 9 Aug 2018 23:40:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0EB738D6F2 for ; Thu, 9 Aug 2018 23:40:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id k16-v6so6193540iom.12 for ; Thu, 09 Aug 2018 16:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OzeLmNzbnQEmcYPW2qgN4jsi4hBfUJhRO9az51lZBLc=; b=ByN1XM8DVcMh6L8ScnK3ke5l/Swa/G0NENvQvn7YsRI1maJ4XpeW/mxDzKAm9IJOMN VEMxhVzPTsb2Yff8JQY2s2rO04Ke8WX3JpoSGVmYLPta/yEkSU1AyFcu6XetpCvGQ1z8 JtaSm6+08aSeGHZ4ZhYCC+8zVUlHfC7OF0M+FZ+tykTiHItMACdoB7uiphR9HpjJbGfC 7GKt0JmO77yFB/PDlhHHGtMvi3JIitmixPcQYS+GZD+at6sgMHPwN3z/SDETcI21YJ/J 1R6Jx/xl25B12xUUIKg8//f2Vs82QMeAT4cvgRMFgzDoPr/xcCWdFeVXHTaXoStu8adW sEqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OzeLmNzbnQEmcYPW2qgN4jsi4hBfUJhRO9az51lZBLc=; b=r5IQGgelrc5gpz50GrdsJ4TTZnCK3bQ6OX5W3lNw9Afj4WVtW7qBxBMxrhlBdzq9ON BDjZL/+pOgToFcjJd38qFrvWz92WR8EYrhEApo5JjNRwyuH7dnReflwQcGBzomgG4kfG Ye4ApmNpBVvCKT0gLB7ol6JZ/J7+K+z6d22xyY1OALDSaOvXDFmrt4FaH9/EkpMSZkX7 hPfAqH7ub3tQxFeij86SeI11X/nQEE2VAtUMWjMM1mJSgjH6GlZspL8omlnwFeAhu2i5 HP3cdcakBhEoFxn7a6yt0P8vxxsugrkBBZoo0En2lK9QiZMRVcs8ffbd+exWj7rhxZP9 ccgQ== X-Gm-Message-State: AOUpUlHh4T3r5utEQggwtDHS6zRnsJ1zhKvfB6e17VkWXY5FoTfP9Rid iB9IJUQIDrIcNZKCP0iN7qxNelMxaY5ZEunLENE+/w== X-Google-Smtp-Source: AA+uWPysgW0z64rJSEUoeopjcNdsZToG1m9uOtbcZcYsc5q+vPAO364yPGv7VunTFU2M9jZbaqXnQ/ty0ytP3vYMSiY= X-Received: by 2002:a6b:3902:: with SMTP id g2-v6mr3526579ioa.168.1533858055125; Thu, 09 Aug 2018 16:40:55 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:381a:0:0:0:0:0 with HTTP; Thu, 9 Aug 2018 16:40:54 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201808092153.w79LrWEZ097986@repo.freebsd.org> From: Warner Losh Date: Thu, 9 Aug 2018 17:40:54 -0600 X-Google-Sender-Auth: 3zCQiINs_CFf6Pyp-pnx-xNo8lA Message-ID: Subject: Re: svn commit: r337554 - in head/sys/cam: . ata nvme scsi To: Scott Long Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 23:40:56 -0000 On Thu, Aug 9, 2018 at 3:56 PM, Scott Long wrote: > > > > On Aug 9, 2018, at 3:53 PM, Conrad Meyer wrote: > > > > Author: cem > > Date: Thu Aug 9 21:53:32 2018 > > New Revision: 337554 > > URL: https://svnweb.freebsd.org/changeset/base/337554 > > > > Log: > > cam(4): Add an xpt-neutral flag indicating a valid panic CCB > > > > No functional change. > > > > Note that this change is careful to set the CCB header xflags after > > foo_fill_bar() routines, which generally zero existing flags. An > earlier > > version of this patch mistakenly set the flag before the fill routines= . > > > > Submitted by: Scott Ferris , jhibbits@ > > Reviewed by: bdrewery@, markj@, and non-committer FreeBSD contributor > Anton Rang > > Sponsored by: Dell EMC Isilon > > What=E2=80=99s the purpose of this flag? I see it gets set in plenty of = places, > but never checked. > It kinda looks like something I recall removing when I did the runccb fixes so they worked when we were dumping. We used to need this, but we don't anymore. I have the same question: Why? Maybe these CAM changes should go through phabricator? Warner