From owner-cvs-all@FreeBSD.ORG Fri Jun 17 00:47:47 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 653601065670; Fri, 17 Jun 2011 00:47:47 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id 3723E8FC18; Fri, 17 Jun 2011 00:47:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id B3AFA170F9; Thu, 16 Jun 2011 20:47:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:reply-to:message-id :subject:subject:from:from:date:date:received; s=aegis; t= 1308271666; bh=cusnAVquLKjhfmyHiYBf+xdMg8YjFGImx8uHPv7nCmE=; b=m E6VOoSxd4pqgVJZXuZIJUvltBeG/lJzAdJtixkpNXc0Bt5fwzQYc1ShQYtJ3WY8J Q5L/un6BMbHtsUS4BiVdJnyBMFW98XHclq0/JdbSnA6s79GF+3Spzwp9ry5EV3en 1dlo2SFy/D9Wiedox7A+8bjrRwRUU3iz6KrRpQFXxo= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id 57zq4CiGfUKo; Thu, 16 Jun 2011 20:47:46 -0400 (EDT) Date: Thu, 16 Jun 2011 20:47:43 -0400 From: Sahil Tandon To: Alexey Dokuchaev Message-ID: <20110617004742.GD19139@magic.hamla.org> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110616164733.GA40181@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Wen Heping , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/tmux Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sahil Tandon List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2011 00:47:47 -0000 On Thu, 2011-06-16 at 16:47:33 +0000, Alexey Dokuchaev wrote: > On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: > > wen 2011-06-16 08:42:28 UTC > > > > Modified files: > > sysutils/tmux Makefile > > Log: > > - Fix build when CFLAGS is set in /etc/make.conf > > Hmm, default CPPFLAGS is empty. Judging just from the diff, instead of > introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which is > bogus in the first place: -I is preprocessor flag) should be enough (no > MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in this > case as well). I am missing something obvious here? Because of the way upstream Makefile handles CPPFLAGS, it is not so straightforward. This was discussed on freebsd-ports: http://lists.freebsd.org/pipermail/freebsd-ports/2011-June/068218.html http://lists.freebsd.org/pipermail/freebsd-ports/2011-May/067930.html -- Sahil Tandon