Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Nov 2012 19:32:35 +0000
From:      Attilio Rao <attilio@freebsd.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/udf...
Message-ID:  <CAJ-FndCXxakT65p8oPFV5%2BjLFJEk5=%2BA=JgrZL3NoS%2BN2PS3ig@mail.gmail.com>
In-Reply-To: <20121109192254.GH73505@kib.kiev.ua>
References:  <201211091802.qA9I2QP6026142@svn.freebsd.org> <20121109181103.GF73505@kib.kiev.ua> <CAJ-FndDX6LY5xJS4Cd1%2BjXfrewtYcgsOacbXcvcwK9h2Px-GnQ@mail.gmail.com> <CAJ-FndDWut=0EbYhRM%2BxeoLjPoYMbcg2QJ8dLOpMiVPFUiMgSQ@mail.gmail.com> <20121109192254.GH73505@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/9/12, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Fri, Nov 09, 2012 at 06:50:52PM +0000, Attilio Rao wrote:
>> On Fri, Nov 9, 2012 at 6:47 PM, Attilio Rao <attilio@freebsd.org> wrote:
>> > On Fri, Nov 9, 2012 at 6:11 PM, Konstantin Belousov
>> > <kostikbel@gmail.com> wrote:
>> >> On Fri, Nov 09, 2012 at 06:02:26PM +0000, Attilio Rao wrote:
>> >>> Author: attilio
>> >>> Date: Fri Nov  9 18:02:25 2012
>> >>> New Revision: 242833
>> >>> URL: http://svnweb.freebsd.org/changeset/base/242833
>> >>>
>> >>> Log:
>> >>>   Complete MPSAFE VFS interface and remove MNTK_MPSAFE flag.
>> >>>   Porters should refer to __FreeBSD_version 1000021 for this change
>> >>> as
>> >>>   it may have happened at the same timeframe.
>> >>>
>> >>> Modified: head/sys/fs/fuse/fuse_vfsops.c
>> >>> ==============================================================================
>> >>> --- head/sys/fs/fuse/fuse_vfsops.c    Fri Nov  9 17:56:49 2012
>> >>> (r242832)
>> >>> +++ head/sys/fs/fuse/fuse_vfsops.c    Fri Nov  9 18:02:25 2012
>> >>> (r242833)
>> >>> @@ -339,7 +339,6 @@ fuse_vfsop_mount(struct mount *mp)
>> >>>
>> >>>       vfs_getnewfsid(mp);
>> >>>       mp->mnt_flag |= MNT_LOCAL;
>> >>> -     mp->mnt_kern_flag |= MNTK_MPSAFE;
>> >>>       if (subtype) {
>> >>>               strlcat(mp->mnt_stat.f_fstypename, ".", MFSNAMELEN);
>> >>>               strlcat(mp->mnt_stat.f_fstypename, subtype,
>> >>> MFSNAMELEN);
>> >>
>> >> mnt_flag update should happen under the mount interlock.
>> >
>> > Yes I already have a patch for that, I'm waiting for testing by flo.
>>
>> http://www.freebsd.org/~attilio/fuse_mnt_flag.patch
>
> Why mp->mnt_data and mp->mnt_stat.f_iosize updates are synchronized ?
> VFS does not modify them.

mnt_data is used within FUSE in a twisted way and MNT_ILOCK is just
convenient for it.
I need to recheck mnt_stat.f_iosize.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndCXxakT65p8oPFV5%2BjLFJEk5=%2BA=JgrZL3NoS%2BN2PS3ig>