From owner-cvs-all Thu Jul 5 12:38:16 2001 Delivered-To: cvs-all@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with SMTP id 5A6B937B409 for ; Thu, 5 Jul 2001 12:37:55 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7913 invoked from network); 5 Jul 2001 19:37:51 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 5 Jul 2001 19:37:51 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200107051714.f65HEwi80357@freefall.freebsd.org> Date: Thu, 05 Jul 2001 12:37:48 -0700 (PDT) From: John Baldwin To: Matt Jacob Subject: RE: cvs commit: src/sys/dev/isp isp_freebsd.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 05-Jul-01 Matt Jacob wrote: > mjacob 2001/07/05 10:14:57 PDT > > Modified files: > sys/dev/isp isp_freebsd.c > Log: > Things have become cinched down more tightly about assertions for Giant. > This uncovered some missing spots where I trade off between isp's lock > and Giant as I enter CAM. I would prefer that you just leave Giant held rather than releasing it until all the code "under" the unlock/lock pair doesn't need Giant at all. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message