Date: Fri, 21 Oct 2016 16:42:40 +0000 (UTC) From: Alan Cox <alc@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r307738 - user/alc/PQ_LAUNDRY/sys/vm Message-ID: <201610211642.u9LGgeFf071663@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: alc Date: Fri Oct 21 16:42:39 2016 New Revision: 307738 URL: https://svnweb.freebsd.org/changeset/base/307738 Log: Revise the comment describing swp_pager_force_pagein(). In particular, correctly explain why the page is immediately placed in the laundry. Requested by: kib Modified: user/alc/PQ_LAUNDRY/sys/vm/swap_pager.c Modified: user/alc/PQ_LAUNDRY/sys/vm/swap_pager.c ============================================================================== --- user/alc/PQ_LAUNDRY/sys/vm/swap_pager.c Fri Oct 21 16:31:58 2016 (r307737) +++ user/alc/PQ_LAUNDRY/sys/vm/swap_pager.c Fri Oct 21 16:42:39 2016 (r307738) @@ -1636,12 +1636,15 @@ swap_pager_isswapped(vm_object_t object, /* * SWP_PAGER_FORCE_PAGEIN() - force a swap block to be paged in * - * This routine dissociates the page at the given index within a - * swap block from its backing store, paging it in if necessary. - * If the page is paged in, it is placed in the laundry queue, - * since it had its backing store ripped out from under it. - * We also attempt to swap in all other pages in the swap block, - * we only guarantee that the one at the specified index is + * This routine dissociates the page at the given index within an object + * from its backing store, paging it in if it does not reside in memory. + * If the page is paged in, it is marked dirty and placed in the laundry + * queue. The page is marked dirty because it no longer has backing + * store. It is placed in the laundry queue because it has not been + * accessed recently. Otherwise, it would already reside in memory. + * + * We also attempt to swap in all other pages in the swap block. + * However, we only guarantee that the one at the specified index is * paged in. * * XXX - The code to page the whole block in doesn't work, so we
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201610211642.u9LGgeFf071663>