From nobody Thu May 16 12:23:21 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vg8Q16Hy5z5LBDr; Thu, 16 May 2024 12:23:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vg8Q13cVXz4nhs; Thu, 16 May 2024 12:23:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715862201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ra2rEUx5MJaSjehOu/i3MoenriLvqBP2EmLnZ0oI230=; b=SMkZxzjFUyw8999RxEtGsu2IaR2J/Ng323sV3i8a97Y3N3IkHZP7xYBdfVmmcvp1wQbMFP F+To2oqw713Tzcwh0Zto1Crh7jPwn9CCltOaovphOTKxeWIfscBoKaI2NR8i6LGmwxWqTo VYI5O/DW74WmMyS3UgFNP4ERcrqqCdMxFwFILeR3dOn+wD0EHP1+Pg0X9t2pR3ThDdb835 wyupBfBRd0AtfWwxSqGkNd7bihaDhVVqfLv7EEW+6+9vmYI/Hzjtk9Kkozsu06UMLjYcCe KxnZ/zSknvyVQU626IhlqE5+oBE5ZeCs5RbbapBmIdREYwaugSP0zfx7UGEZOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715862201; a=rsa-sha256; cv=none; b=G4HUJkbdtD7mvVYAm/X2apTrbcQ/u6T0tdMMasUIlPxK86f9BAkuRASuLbyTPVDPuZ/a/8 ZshbV0yGelGG+dRoY58BJDddHddq1fpuq5NEd+jsCyzD1tjLguRIFQ8Ux41hAmovEeQWe/ LxPNvWWee+G9s/Opkv4xTCfvloQLnqmYE1mwIW8013AMHL+Mvn88P0PM2TYsZ91Zp6waK1 HR8ARp0peFZFCJeHOwluMVbetgRruTIru/NSkv9BK6hWwWXzXmlwpzLnl4u8NNa7t/ESdw 288LciCUwUTPh8iM04xOQ8OnJv3yLZ/3X54OSEXRXgLec2yhsT+Ds5iStsc9ZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715862201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ra2rEUx5MJaSjehOu/i3MoenriLvqBP2EmLnZ0oI230=; b=yjxGlvE0WKf2sVtsOpBMye6KprM6tqkOlI6icca+zV68Nk28PKeSHyTz7bF9dBPYZ1QVyS O3crVWYLEb14uGwLXoh7CuZhtKDflc1qQzI+qB1EbGJSC3DDL48f2rWW8J9ldDWJ3N671g dtgUTEX8qFujHkYdYiFFYjjbZzofpdLfjqwB8OWGU+6yJmjvxDmWz4ZG+5LPHRwabfHR08 oiA09ugHKjD9herXtslr2e7RML2x9GkKmH+KqugxR2l7wJttMmmmYHYjBVZunrK+CwNVVI bQLPtmUEYmb2Y/Zm0/P93fFGB4W/baLuHbseuhPA9swmQOJoHySIfRUhaA2l2A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vg8Q13CgVzyMD; Thu, 16 May 2024 12:23:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44GCNLNs045159; Thu, 16 May 2024 12:23:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44GCNL05045156; Thu, 16 May 2024 12:23:21 GMT (envelope-from git) Date: Thu, 16 May 2024 12:23:21 GMT Message-Id: <202405161223.44GCNL05045156@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 147c7e4dde23 - releng/14.1 - Increase IOAPIC_MAX_ID to 255 (from 254) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.1 X-Git-Reftype: branch X-Git-Commit: 147c7e4dde23b3b787b4fb8b754f043f64ab7adb Auto-Submitted: auto-generated The branch releng/14.1 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=147c7e4dde23b3b787b4fb8b754f043f64ab7adb commit 147c7e4dde23b3b787b4fb8b754f043f64ab7adb Author: Ed Maste AuthorDate: 2024-05-10 17:40:59 +0000 Commit: Ed Maste CommitDate: 2024-05-16 12:23:05 +0000 Increase IOAPIC_MAX_ID to 255 (from 254) A test system provided by AMD panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is acceptable, so increase the limit. Reviewed by: jhb, kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45157 (cherry picked from commit 4e3286818327453efd8e4c133928ba26a169567a) (cherry picked from commit 18119e711f1c844bd6eacf5afc8d4cdec3ac8085) Approved by: re (cperciva) --- sys/x86/include/apicvar.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/x86/include/apicvar.h b/sys/x86/include/apicvar.h index 10016e291b9b..ac6a82659e34 100644 --- a/sys/x86/include/apicvar.h +++ b/sys/x86/include/apicvar.h @@ -78,7 +78,12 @@ #define MAX_APIC_ID 0x800 #define APIC_ID_ALL 0xffffffff -#define IOAPIC_MAX_ID xAPIC_MAX_APIC_ID +/* + * The 0xff ID is used for broadcast IPIs for local APICs when not using + * x2APIC. IPIs are not sent to I/O APICs so it's acceptable for an I/O APIC + * to use that ID. + */ +#define IOAPIC_MAX_ID 0xff /* I/O Interrupts are used for external devices such as ISA, PCI, etc. */ #define APIC_IO_INTS (IDT_IO_INTS + 16)