From owner-svn-src-all@FreeBSD.ORG  Wed Jul 21 17:26:20 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 736BF1065672; Wed, 21 Jul 2010 17:26:20 +0000 (UTC)
Date: Wed, 21 Jul 2010 17:26:20 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ed Schouten <ed@80386.nl>
Message-ID: <20100721172620.GA21742@FreeBSD.org>
References: <201007210843.o6L8hmo5064622@svn.freebsd.org>
	<20100721090623.GA21607@FreeBSD.org>
	<20100721091208.GG1742@hoeg.nl> <20100721165849.GH1742@hoeg.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20100721165849.GH1742@hoeg.nl>
User-Agent: Mutt/1.4.2.1i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Kai Wang <kaiw@FreeBSD.org>
Subject: Re: svn commit: r210321 - head/lib/libelf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jul 2010 17:26:20 -0000

On Wed, Jul 21, 2010 at 06:58:49PM +0200, Ed Schouten wrote:
> * Ed Schouten <ed@80386.nl> wrote:
> > * Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > > (Just picking random of the similar commits): guys, please, try to
> > > uniformly align commit meta tags:
> > 
> > I guess it was aligned properly using tabs, but the whitespace added to
> > the beginning of the line causes it to jump one tab forward.
> 
> It would be nice if the SVN commit hook would convert tabs to spaces
> before adding the leading whitespace.

I believe this is not the right thing to do.  First, my original
complaint towards kaiw@ was a mistake on my behalf: I miscalculated
characters and fell under impression alignment was wrong regardless of
email two-space padding (bde@ corrected me on this).  Second, I think
blindly converting tabs to spaces would bring even more mess to
alignment than we happen to have now.  I guess that the best we can do
here is to take this occasion for chance to remind all of us that tags
values should be aligned properly... using tabs.

./danfe