Date: Wed, 21 Jul 2010 17:26:20 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Kai Wang <kaiw@FreeBSD.org> Subject: Re: svn commit: r210321 - head/lib/libelf Message-ID: <20100721172620.GA21742@FreeBSD.org> In-Reply-To: <20100721165849.GH1742@hoeg.nl> References: <201007210843.o6L8hmo5064622@svn.freebsd.org> <20100721090623.GA21607@FreeBSD.org> <20100721091208.GG1742@hoeg.nl> <20100721165849.GH1742@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 21, 2010 at 06:58:49PM +0200, Ed Schouten wrote: > * Ed Schouten <ed@80386.nl> wrote: > > * Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > > (Just picking random of the similar commits): guys, please, try to > > > uniformly align commit meta tags: > > > > I guess it was aligned properly using tabs, but the whitespace added to > > the beginning of the line causes it to jump one tab forward. > > It would be nice if the SVN commit hook would convert tabs to spaces > before adding the leading whitespace. I believe this is not the right thing to do. First, my original complaint towards kaiw@ was a mistake on my behalf: I miscalculated characters and fell under impression alignment was wrong regardless of email two-space padding (bde@ corrected me on this). Second, I think blindly converting tabs to spaces would bring even more mess to alignment than we happen to have now. I guess that the best we can do here is to take this occasion for chance to remind all of us that tags values should be aligned properly... using tabs. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100721172620.GA21742>