From owner-freebsd-current Fri Dec 10 10:10:52 1999 Delivered-To: freebsd-current@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.100.7]) by hub.freebsd.org (Postfix) with ESMTP id 427D815085 for ; Fri, 10 Dec 1999 10:10:49 -0800 (PST) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.9.3/8.9.3) with ESMTP id NAA86168; Fri, 10 Dec 1999 13:10:26 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Fri, 10 Dec 1999 13:16:16 -0500 To: Alfred Perlstein , Andre Albsmeier From: Garance A Drosihn Subject: Re: NO! Re: [PATCHES] Two fixes for lpd/lpc for review and test Cc: Warner Losh , current@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 2:33 AM -0800 12/10/99, Alfred Perlstein wrote: >Can someone take a look at this? > >Basically, it makes the link to the file, if it can unlink the original >it will then chown the spool file if it can't delete or read the original >then the user didn't have permission and it backs out. I'm thinking you'd what to add an lstat call after creating the hardlink. Check the new file to see if it's a symlink, and if it is, then delete the new file and go to nohardlink. Then proceed with the rest of your code (which looks fine to me, but remember I'm the guy who wrote a message explicitly for one mailing list, and then sent it to the other one...). I'm not sure on that, and haven't had time to look at the code yet. I'm just wondering about the case where a user might do a lpr -r -s somesymlink and want to be sure this does the right thing. I suspect that currently (without this patch) lpr will copy the REAL file, and then remove the symlink. I don't think we want to hard-link to the symlink, and then remove the original symlink. Remember, my mind is tired enough that I could easily be making things up here... It may be that the situation I'm wondering about is already covered by other checks in the code. --- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or drosih@rpi.edu Rensselaer Polytechnic Institute To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message