From owner-svn-src-head@FreeBSD.ORG  Mon Oct 31 16:42:05 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6C6C106564A;
	Mon, 31 Oct 2011 16:42:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 8EC148FC15;
	Mon, 31 Oct 2011 16:42:05 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 31B2846B0A;
	Mon, 31 Oct 2011 12:42:05 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id A482B8A02E;
	Mon, 31 Oct 2011 12:42:04 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Peter Holm <pho@freebsd.org>
Date: Mon, 31 Oct 2011 12:41:41 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; )
References: <201110311501.p9VF1lrf020688@svn.freebsd.org>
In-Reply-To: <201110311501.p9VF1lrf020688@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201110311241.42067.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 31 Oct 2011 12:42:04 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226967 - head/sys/ufs/ufs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Oct 2011 16:42:05 -0000

On Monday, October 31, 2011 11:01:47 am Peter Holm wrote:
> Author: pho
> Date: Mon Oct 31 15:01:47 2011
> New Revision: 226967
> URL: http://svn.freebsd.org/changeset/base/226967
> 
> Log:
>   The kern_renameat() looks up the fvp using the DELETE flag, which causes
>   the removal of the name cache entry for fvp.
>   
>   Reported by:	Anton Yuzhaninov <citrin citrin ru>
>   In collaboration with:	kib
>   MFC after:	1 week

Hmm, the log message doesn't seem to quite match the change?  Was it 
truncated?

> Modified:
>   head/sys/ufs/ufs/ufs_vnops.c
> 
> Modified: head/sys/ufs/ufs/ufs_vnops.c
> 
==============================================================================
> --- head/sys/ufs/ufs/ufs_vnops.c	Mon Oct 31 10:53:27 2011	(r226966)
> +++ head/sys/ufs/ufs/ufs_vnops.c	Mon Oct 31 15:01:47 2011	(r226967)
> @@ -1519,6 +1519,13 @@ relock:
>  		cache_purge(fdvp);
>  	}
>  	error = ufs_dirremove(fdvp, fip, fcnp->cn_flags, 0);
> +	/*
> +	 * As the relookup of the fvp is done in two steps:
> +	 * ufs_lookup_ino() and then VFS_VGET(), another thread might do a
> +	 * normal lookup of the from name just before the VFS_VGET() call,
> +	 * causing the cache entry to be re-instantiated.
> +	 */
> +	cache_purge(fvp);
>  
>  unlockout:
>  	vput(fdvp);
> 

-- 
John Baldwin