From owner-freebsd-bugs@FreeBSD.ORG  Sat Sep  6 06:20:47 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 214F6106564A;
	Sat,  6 Sep 2008 06:20:47 +0000 (UTC)
	(envelope-from freebsdntpd@oldach.net)
Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250])
	by mx1.freebsd.org (Postfix) with ESMTP id AE52F8FC12;
	Sat,  6 Sep 2008 06:20:46 +0000 (UTC)
	(envelope-from freebsdntpd@oldach.net)
Received: from sep.oldach.net (hmo.in-dsl.de [217.197.85.210])
	by rigel.oldach.net (8.14.2/8.14.2/hmo30jul04) with ESMTP id
	m86643E6017028
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Sat, 6 Sep 2008 08:04:03 +0200 (CEST)
	(envelope-from freebsdntpd@oldach.net)
Received: from sep.oldach.net (localhost [127.0.0.1])
	by sep.oldach.net (8.14.3/8.14.3/hmo26jun05) with ESMTP id
	m86642ru005777
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 6 Sep 2008 08:04:02 +0200 (CEST)
	(envelope-from freebsdntpd@oldach.net)
Received: (from hmo@localhost)
	by sep.oldach.net (8.14.3/8.14.3/Submit/hmo26jun05) id m86642xN005776; 
	Sat, 6 Sep 2008 08:04:02 +0200 (CEST)
	(envelope-from freebsdntpd@oldach.net)
Message-Id: <200809060604.m86642xN005776@sep.oldach.net>
In-Reply-To: <200602051330.k15DU3DT001208@freefall.freebsd.org> from
	"FreeBSD-gnats-submit@FreeBSD.org" at "5 Feb 2006 13:30:03"
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Date: Sat, 6 Sep 2008 08:04:01 +0200 (CEST)
From: freebsdntpd@oldach.net (Helge Oldach)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Ollivier Robert <roberto@FreeBSD.org>
Subject: Re: bin/92839: contrib/ntp PARSE buffer overrun [patch]
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Sep 2008 06:20:47 -0000

After Ollivier's recent update of ntp two buffer overruns still remain.
The patch below fixes them:


--- clk_rawdcf.c	2008-09-06 07:59:47.000000000 +0200
+++ clk_rawdcf.c.ctm	2008-09-04 23:01:34.000000000 +0200
@@ -229,7 +229,7 @@
 	unsigned char *c = dcfprm->zerobits;
 	int i;
 
-	parseprintf(DD_RAWDCF,("parse: convert_rawdcf: \"%.*s\"\n", size, buffer));
+	parseprintf(DD_RAWDCF,("parse: convert_rawdcf: \"%s\"\n", buffer));
 
 	if (size < 57)
 	{
@@ -320,7 +320,7 @@
 		 * bad format - not for us
 		 */
 #ifndef PARSEKERNEL
-		msyslog(LOG_ERR, "parse: convert_rawdcf: parity check FAILED for \"%.*s\"\n", size, buffer);
+		msyslog(LOG_ERR, "parse: convert_rawdcf: parity check FAILED for \"%s\"\n", buffer);
 #endif
 		return CVT_FAIL|CVT_BADFMT;
 	}