From owner-freebsd-current@FreeBSD.ORG Wed Aug 13 00:32:39 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0229B106566C for ; Wed, 13 Aug 2008 00:32:39 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id 7B8618FC16 for ; Wed, 13 Aug 2008 00:32:38 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id E3492198DF1; Wed, 13 Aug 2008 02:32:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id D6D9A198DEF; Wed, 13 Aug 2008 02:32:36 +0200 (CEST) Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id C09AD198DEE; Wed, 13 Aug 2008 02:32:36 +0200 (CEST) Received: from localhost.my.domain ([80.129.162.115]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.0.1HF110) with ESMTP id 2008081302323568-23188 ; Wed, 13 Aug 2008 02:32:35 +0200 Received: by localhost.my.domain (sSMTP sendmail emulation); Wed, 13 Aug 2008 02:36:27 +0200 Date: Wed, 13 Aug 2008 02:36:26 +0200 From: Alexey Shuvaev To: Ed Schouten Message-ID: <20080813003626.GA1007@localhost.my.domain> Mail-Followup-To: Ed Schouten , freebsd-current@freebsd.org References: <20080812135142.GA1033@wep4017.physik.uni-wuerzburg.de> <20080812151038.GA99951@hoeg.nl> Mime-Version: 1.0 In-Reply-To: <20080812151038.GA99951@hoeg.nl> User-Agent: Mutt/1.4.2.3i Organization: Universitaet Wuerzburg X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.0.1HF110 | April 11, 2008) at 08/13/2008 02:32:35 AM, Serialize by Router on domino1/uni-wuerzburg(Release 8.0.1HF110 | April 11, 2008) at 08/13/2008 02:32:36 AM, Serialize complete at 08/13/2008 02:32:36 AM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Cc: freebsd-current@freebsd.org Subject: Re: POSIX compliant termios.h? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 00:32:39 -0000 On Tue, Aug 12, 2008 at 05:10:38PM +0200, Ed Schouten wrote: > Wait wait wait... Deja vu. brlcad is broken? I submitted a patch for it > in December 2007, which got committed in February. > > http://bugs.freebsd.org/119096 > > I even contacted the maintainer of brlcad to make sure a portable > version of it got integrated. Gah! > Yes, I think it is committed upstream. But it was about src/vas4/vas_io.c. Now it is time to look at src/libtermio/termio.c. Namely, the following used to work: 31 32 #if HAVE_SYS_IOCTL_COMPAT_H 33 # include 34 # define TAB3 (TAB1|TAB2) 35 # if !defined(OCRNL) 36 # define OCRNL 0000010 37 # endif 38 #endif 39 I think, this peace of code is obsolete on CURRENT now. Compiler says that neither TAB1 or TAB2 are declared. As it is CURRENT we can wait a while for the things to settle down. FYI, the brlcad code is picking up the HAVE_TERMIOS_H case: 40 41 /* 42 * This file will work IFF one of these three flags is set: 43 * HAVE_TERMIOS_H use POXIX termios and tcsetattr() call with XOPE N flags 44 * SYSV use SysV Rel3 termio and TCSETA ioctl 45 * BSD use Version 7 / BSD sgttyb and TIOCSETP ioctl 46 */ 47 [skip] 286 #ifdef HAVE_TERMIOS_H 287 curr_tio[fd].c_oflag |= TAB3; /* Tab expansion ON. */ 288 (void)tcsetattr( fd, TCSANOW, &curr_tio[fd] ); 289 #endif [skip] 310 #ifdef HAVE_TERMIOS_H 311 curr_tio[fd].c_oflag &= ~TAB3; /* Tab expans. OFF. */ 312 (void)tcsetattr( fd, TCSANOW, &curr_tio[fd] ); 313 #endif Alexey.