From owner-freebsd-bugs@FreeBSD.ORG  Mon May 12 07:50:19 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A18CC37B401
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 12 May 2003 07:50:19 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 43A1943FE1
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 12 May 2003 07:50:19 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h4CEoIUp015237
	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 12 May 2003 07:50:18 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h4CEoI6S015236;
	Mon, 12 May 2003 07:50:18 -0700 (PDT)
Date: Mon, 12 May 2003 07:50:18 -0700 (PDT)
Message-Id: <200305121450.h4CEoI6S015236@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jilles Tjoelker <jilles@stack.nl>
Subject: Re: kern/51964: panic: race condition with realitexpire() called
	for	zombie
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Jilles Tjoelker <jilles@stack.nl>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 May 2003 14:50:19 -0000

The following reply was made to PR kern/51964; it has been noted by GNATS.

From: Jilles Tjoelker <jilles@stack.nl>
To: Tor.Egge@cvsup.no.freebsd.org
Cc: FreeBSD-gnats-submit@freebsd.org, svdb@stack.nl, unix@stack.nl
Subject: Re: kern/51964: panic: race condition with realitexpire() called for	zombie
Date: Mon, 12 May 2003 16:43:25 +0200

 On Sat, May 10, 2003 at 05:07:56PM +0000, Tor.Egge@cvsup.no.freebsd.org wrote:
 > The enclosed patch should fix the problem if your source is newer than
 > "2003/05/01 14:16:38 PDT" (the struct proc mutex must be persistent).
 
 > If callout_pending() is true then callout_reset() has been called.
 > If callout_active() is false then callout_stop() has been called.
 
 I have upgraded the system and applied the patch. Brief testing
 indicates I can run the itimer program for more than 15 minutes without
 a crash.
 
 > ---------------------------
 > Index: sys/kern/kern_time.c
 > ===================================================================
 > RCS file: /home/ncvs/src/sys/kern/kern_time.c,v
 > retrieving revision 1.101
 > diff -u -r1.101 kern_time.c
 > --- sys/kern/kern_time.c	26 Feb 2003 17:16:38 -0000	1.101
 > +++ sys/kern/kern_time.c	10 May 2003 16:44:41 -0000
 > @@ -527,6 +527,12 @@
 >  
 >  	p = (struct proc *)arg;
 >  	PROC_LOCK(p);
 > +	/* Check for callout being active */
 > +	if (callout_pending(&p->p_itcallout) ||
 > +	    !callout_active(&p->p_itcallout)) {
 > +		PROC_UNLOCK(p);
 > +		return;
 > +	}
 >  	psignal(p, SIGALRM);
 >  	if (!timevalisset(&p->p_realtimer.it_interval)) {
 >  		timevalclear(&p->p_realtimer.it_value);
 > ---------------------------