From owner-freebsd-current@FreeBSD.ORG  Wed Jun 11 14:53:28 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 41DBF37B417; Wed, 11 Jun 2003 14:53:28 -0700 (PDT)
Received: from aslan.scsiguy.com (mail.scsiguy.com [63.229.232.106])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 53FA143F93; Wed, 11 Jun 2003 14:53:27 -0700 (PDT)
	(envelope-from gibbs@scsiguy.com)
Received: from localhost (aslan.scsiguy.com [63.229.232.106])
	by aslan.scsiguy.com (8.12.9/8.12.8) with ESMTP id h5BLppvl005314;
	Wed, 11 Jun 2003 15:51:52 -0600 (MDT)
	(envelope-from gibbs@scsiguy.com)
Date: Wed, 11 Jun 2003 15:51:51 -0600
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: "M. Warner Losh" <imp@bsdimp.com>, gibbs@scsiguy.com
Message-ID: <404880000.1055368311@caspian.scsiguy.com>
In-Reply-To: <20030611.154531.59692646.imp@bsdimp.com>
References: <20030609210919.33379@hydrogen.funkthat.com>
	<20030609.224621.71095461.imp@bsdimp.com>
	<361340000.1055367125@caspian.scsiguy.com>
	<20030611.154531.59692646.imp@bsdimp.com>
X-Mailer: Mulberry/3.0.3 (Linux/x86)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
cc: gurney_j@resnet.uoregon.edu
cc: freebsd-current@freebsd.org
cc: gurney_j@efn.org
cc: ticso@cicely.de
cc: freebsd-sparc64@freebsd.org
Subject: Re: PCI bus numbering and orphaned devices
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: "Justin T. Gibbs" <gibbs@scsiguy.com>
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2003 21:53:28 -0000

> : > I'm thinking that the loop should be more like:
> : >
> : > 		pcifunchigh = 0;
> : > 		f = 0;
> : > 		hdrtype	= REG(PCIR_HEADERTYPE, 1);
> : > 		if (hdrtype & 0x7f > 2)
> : > 			continue;
> :
> : My only complaint about this is that if no device is present in the
> : slot, won't you just get all bits set in whatever you read?  If so,
> : the headertype check should be better bounded.
>
> hdrtype would be 0xff.  0xff & 0x7f is 0x7f, which is greater than 2.

Sorry.  Read the test backwards.

--
Justin