From owner-freebsd-ports-bugs@freebsd.org Tue Jul 19 21:03:39 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D84BCB9EA8C for ; Tue, 19 Jul 2016 21:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C54B51E38 for ; Tue, 19 Jul 2016 21:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6JL3dUH045339 for ; Tue, 19 Jul 2016 21:03:39 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 211152] benchmarks/iozone: Build fails on typedef redefinition with different types ('long long' vs '__off64_t' (aka 'long')) Date: Tue, 19 Jul 2016 21:03:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markmi@dsl-only.net X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 21:03:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211152 --- Comment #35 from Mark Millard --- (In reply to Kubilay Kocak from comment #32) I believe that the following part of the overall changes are all that was required to deal with the original build failure reported (iozone 434 or 444 vintages): typedef off_t off64_t; #endif +#if defined(__FreeBSD__) +#define __off64_t_defined +typedef off_t off64_t; +#endif #ifndef solaris #ifndef off64_t and optionally (__off64_t_defined was sufficient to avoid the typedef): #ifndef SCO_Unixware_gcc #ifndef UWIN #ifndef __DragonFly__ +#ifndef __FreeBSD__ typedef long long off64_t; #endif #endif with its matching: #endif #endif #endif +#endif But the __DragonFly__ in the original code base was also optional because of __off64_t_defined already being defined for that context. So the above optional part-pair maintains the style of handling in the original. One possibility for the CACHE_LINE_SIZE issue for FreeBSD is: +#if !defined(CACHE_LINE_SIZE) #define CACHE_LINE_SIZE 32 +#endif Has anyone contacted the upstream author ( capps@iozone.org ) to see what t= heir criteria are for changes to go upstream? For example: what range of vintage= s of C are to be supported? --=20 You are receiving this mail because: You are the assignee for the bug.=