From nobody Tue Feb 10 00:42:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f92pC4hWWz6R4dl; Tue, 10 Feb 2026 00:42:27 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f92pC485xz4FJg; Tue, 10 Feb 2026 00:42:27 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770684147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UYggjxCfwRXWVEPGKiqkR6hZBeXzs6pzCMHUxFHU5H4=; b=lRvkzX8BhbaGQLZPGS0WJsv1grzND9NEFmDR2tEEpvv3U+/1werzdLASkOHP4g24xRDKN3 i6jcsHvA+zbdu2uH9YjTDWufL0pkX8dk9sKPIdvb0aEhXqkyjm0LgJReWVFQPbpS23beo3 rGOlS6DQXXZ7mvCKUtVp6cflbXWf97pJH8A/wFOgY/9plHPWus2HQWWASeDrTVpME/DGQ/ m8zu1pYjlJrgnE+VFfyPRG3HEnIprhzQDQliwQodKImlcXsgWkKes6tvPybAcLxCm8IiQ8 O20dw/9UQK1p2XyFIDZef+Gym16ujUFeg19bUnUvnblOHI7xwyOWXzmXplMbeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770684147; a=rsa-sha256; cv=none; b=K0dClKe2npPnCL8mujKhejO34CW3EdRYGb5IRsZdDe6gE3GA5eCl/gagWs9ZHPNPbRQSgg CqmYbZPDs4eIY4VZ3sKuCZShHkQ6kNuxSeyP2/N1wFuZULITSmR0sP3e4t0PacZgQ69BXW I/v/CWaeBgmv9gdWL6d3+w80rHBKjqLVuH4iOHOYEY/VxrDj9z5Jnp+U1AK4LZRm55O+XC 4i6A4TliezavslWI/d5nd/fjq0GrjdimiFBTDGTo52Op++0bmFqUpY6nsqBtUPjHQERUYH 1tqzeqViojhYh/SBVnU3pGcfAVEzN/bb8UvRwI28QrBNprJDVnoaz5F2L0xCpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770684147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UYggjxCfwRXWVEPGKiqkR6hZBeXzs6pzCMHUxFHU5H4=; b=POjvU6HlrUZYxDiKkfZNl/P+/9BfJmPxEGkFAyOkG/DSoMnEbEQJV4BcCPUlSw1jyV++JB qIOKNHXCKMPkRtKAXhrmzBvtjAHz1DJII/jH12AZb8nx+DD0QXkwJkHpM9afiiA3I+PhSp Q1IHC/yCrNcRwjNjOXndyRavl/ZTjbqJx2cq0abyyQK4BIiYFYBP9bf2PLZfrWYQgR5T/B FJ+SOzpBRs3xLkBVfG/hjD7aVayXquu1m3Tt487dG+xJR6tO3Pwn3qvyinYOmrkPEoNoqR 73StBKh+8xb/1aZwWcMiOB9/Ka6+27ehv27ZxFKC4J/YflESzNeQl9Kd7kGAMA== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E8" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f92pC2tc4zBWv; Tue, 10 Feb 2026 00:42:27 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id CA595A64805; Tue, 10 Feb 2026 00:42:07 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 865C22D029E7; Tue, 10 Feb 2026 00:42:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id C5lW18w46QRe; Tue, 10 Feb 2026 00:42:24 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 640C82D029D8; Tue, 10 Feb 2026 00:42:24 +0000 (UTC) Date: Tue, 10 Feb 2026 00:42:24 +0000 (UTC) From: "Bjoern A. Zeeb" To: Konstantin Belousov , Brooks Davis cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ad639400dc9f - main - sys/event.h: use freebsd32_uint64_t for kevent32 64bit members In-Reply-To: <698a3052.36544.6d7c1a7c@gitrepo.freebsd.org> Message-ID: <0qrpp6r-1374-7r1s-8o3o-9280q483q549@mnoonqbm.arg> References: <698a3052.36544.6d7c1a7c@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Mon, 9 Feb 2026, Konstantin Belousov wrote: Hi, > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ad639400dc9f1c5aec470996473bb54edc113dba > > commit ad639400dc9f1c5aec470996473bb54edc113dba > Author: Konstantin Belousov > AuthorDate: 2026-02-05 19:22:44 +0000 > Commit: Konstantin Belousov > CommitDate: 2026-02-09 18:57:19 +0000 > > sys/event.h: use freebsd32_uint64_t for kevent32 64bit members > > Reviewed by: brooks > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D55135 It seems that this commit breaks drm-kmod radeon drivers at least. I assume given the abi_compat.h now gets exposed via event.h into LinuxKPI and "CP2" etc. are just very generic names. 26 In file included from /home/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/radeon/ci_dpm.c:31: 27 /home/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/radeon/cikd.h:852:10: error: 'CP2' macro redefined [-Werror,-Wmacro-redefined] 28 852 | #define CP2 (1 << 2) 29 | ^ 30 /home/bz/git/FreeBSD/freebsd-src/sys/sys/abi_compat.h:73:9: note: previous definition is here 31 73 | #define CP2(src, dst, sfld, dfld) do { \ 32 | ^ 33 1 error generated. > --- > sys/compat/freebsd32/freebsd32_misc.c | 38 ++++++----------------------------- > sys/sys/event.h | 6 ++++-- > usr.bin/kdump/kdump.c | 6 +----- > 3 files changed, 11 insertions(+), 39 deletions(-) > ... ... ... > diff --git a/sys/sys/event.h b/sys/sys/event.h > index ebbcdb703183..0ba8e4796208 100644 > --- a/sys/sys/event.h > +++ b/sys/sys/event.h > @@ -104,6 +104,8 @@ struct freebsd11_kevent { > #endif > > #if defined(_WANT_KEVENT32) || defined(_KERNEL) > +#include > + > struct kevent32 { > __uint32_t ident; /* identifier for this event */ > short filter; /* filter for event */ ... -- Bjoern A. Zeeb r15:7