From nobody Thu Feb 5 14:45:43 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f6KlX2Rtlz6QdSl for ; Thu, 05 Feb 2026 14:45:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f6KlX0lBqz3KSp for ; Thu, 05 Feb 2026 14:45:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770302744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rms4sdlfxsLKcd2YPTpMuWIGJNmeH3agzHfznsJ3F3k=; b=nYXKsA9mGQD3wH3rNVr8CA0wrVGSp5yGh4/e9br3TQDxJSUcai/pbiCsxmWfl6ItoRBKfB w/9rDBFeBKNdIzGnm1hcrE3M3cAVXLGSusUswT9Zi8LEaYBdtfdkTFs+ChUOLvIgJBQkxS WpEiDnLuZn5DPoKHquyNxNaneSCgocxPqBtVtDddmCaFi4QRazwWCoMrcDDLDKmulKs7br zpoii9wERmDgvwK7v2oMwqF8kdPkoBoyGvYr3D89v5HZC3vJ2JIv57aJFunfMllj7zyQpK Ebia0SMehhUnrc5JnIhkEXV7CBPP+OSorjcdaY7asE8XEdrMiyvqbRcRNBas2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770302744; a=rsa-sha256; cv=none; b=JFYi4OVktZJa6A3lquYbBEjKRit4VWcCjN9j82Zs8q0H/t6nzWq6YQ1ZAtJhlfacWfAhth kDocXio3c4hx+wca+z0Bckws78i2eD6grcYPFp8s8OnIdY1hiaVVj5Ae69paAukmjPGAuO z1wTIarO5Bn60ANTeyo6Wrcck0OuhT2Ip8ZESaB4mDexpvCut4gEVXY/h2fOn3llPQ6eVa k5nyz0QZyitWbTlbXgKJ0zH3rvZfOWSULCgU4RC2P2yhHTqlAIORtWYOgxJ0PPyesHmeg2 hkxiTEPBP5YyMBHfLPkFtqZMpdE+WCidvjOG4e+HLGGY1n4OgDEgE+kGML5Efw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770302744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rms4sdlfxsLKcd2YPTpMuWIGJNmeH3agzHfznsJ3F3k=; b=g/7LiRNeTfdZRaVScW0iIErrwjftqAwN8EDb+g1U38uuDdOqqra0n6+578BtNdeyQ2LBTQ YhOD1RGHGkzNUyLPyaGuRc1jvz0y5abNHgwJwbdghRGpkvjJCQ8xfDOFxVxXaNOTZdzZ4x NLGJ5dbqG8ig/WbNq1XG3h2YkB3c6P0R19CxcevCjVp03wEWYUeaLC2146tyqsAsI03mtr 9hnoWmnvkq0vFfRQA7KvGfSGkWpu+Y/W6tm19Aa9U/vrU2azWGbZLfIQZUbg5W68WBvQWa 45vo0f21o+7QhfEgUYInadZ8uX5l0IPkuXigsVMH1m7dFrFWKI+K4gXqQwl//Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f6KlW6bJBzZlY for ; Thu, 05 Feb 2026 14:45:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c336 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Feb 2026 14:45:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: a689bfa4e25a - main - libdiff: Simplify truncation detection List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a689bfa4e25af8307709dc12f75b0e02a65abf18 Auto-Submitted: auto-generated Date: Thu, 05 Feb 2026 14:45:43 +0000 Message-Id: <6984ad17.3c336.366a8f11@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a689bfa4e25af8307709dc12f75b0e02a65abf18 commit a689bfa4e25af8307709dc12f75b0e02a65abf18 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-05 14:39:34 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-05 14:39:34 +0000 libdiff: Simplify truncation detection * Adjust the comment to reflect the fact that SIGBUS can occur not only if the file is truncated, but also if an I/O error occurs while paging in any part of it. * Instead of setting a flag, just return EIO. * Adjust the unit test accordingly. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: thj, kevans Differential Revision: https://reviews.freebsd.org/D55108 --- contrib/libdiff/include/diff_main.h | 1 - contrib/libdiff/lib/diff_atomize_text.c | 12 +++++++----- lib/libdiff/tests/libdiff_test.c | 3 +-- usr.bin/diff/diffreg_new.c | 4 ---- 4 files changed, 8 insertions(+), 12 deletions(-) diff --git a/contrib/libdiff/include/diff_main.h b/contrib/libdiff/include/diff_main.h index 11700580db4b..04a6c6e748c9 100644 --- a/contrib/libdiff/include/diff_main.h +++ b/contrib/libdiff/include/diff_main.h @@ -118,7 +118,6 @@ struct diff_data { /* Flags set by file atomizer. */ #define DIFF_ATOMIZER_FOUND_BINARY_DATA 0x00000001 -#define DIFF_ATOMIZER_FILE_TRUNCATED 0x00000002 /* Flags set by caller of diff_main(). */ #define DIFF_FLAG_IGNORE_WHITESPACE 0x00000001 diff --git a/contrib/libdiff/lib/diff_atomize_text.c b/contrib/libdiff/lib/diff_atomize_text.c index d8a69733fc00..9ed611cce4b2 100644 --- a/contrib/libdiff/lib/diff_atomize_text.c +++ b/contrib/libdiff/lib/diff_atomize_text.c @@ -141,6 +141,7 @@ diff_data_atomize_text_lines_mmap(struct diff_data *d) bool embedded_nul = false; unsigned int array_size_estimate = d->len / 50; unsigned int pow2 = 1; + int ret = DIFF_RC_OK; while (array_size_estimate >>= 1) pow2++; @@ -152,13 +153,14 @@ diff_data_atomize_text_lines_mmap(struct diff_data *d) sigaction(SIGBUS, &act, &oact); if (sigsetjmp(diff_data_signal_env, 0) > 0) { /* - * The file was truncated while we were reading it. Set - * the end pointer to the beginning of the line we were - * trying to read, adjust the file length, and set a flag. + * The file was truncated while we were reading it, or an + * I/O error occurred. Set the end pointer to the + * beginning of the line we were trying to read, adjust + * the file length, and set the return value to an error. */ end = pos; d->len = end - d->data; - d->atomizer_flags |= DIFF_ATOMIZER_FILE_TRUNCATED; + ret = EIO; } while (pos < end) { const uint8_t *line_start = pos, *line_end = pos; @@ -203,7 +205,7 @@ diff_data_atomize_text_lines_mmap(struct diff_data *d) if (embedded_nul) d->atomizer_flags |= DIFF_ATOMIZER_FOUND_BINARY_DATA; - return DIFF_RC_OK; + return ret; } static int diff --git a/lib/libdiff/tests/libdiff_test.c b/lib/libdiff/tests/libdiff_test.c index e82a36f3d38a..2a7c1b37e2c2 100644 --- a/lib/libdiff/tests/libdiff_test.c +++ b/lib/libdiff/tests/libdiff_test.c @@ -45,10 +45,9 @@ ATF_TC_BODY(diff_atomize_truncated, tc) rewind(f); ATF_REQUIRE(truncate(fn, size / 2) == 0); ATF_REQUIRE((p = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fileno(f), 0)) != MAP_FAILED); - ATF_REQUIRE(diff_atomize_file(&d, &cfg, f, p, size, 0) == 0); + ATF_REQUIRE(diff_atomize_file(&d, &cfg, f, p, size, 0) == EIO); ATF_REQUIRE((size_t)d.len <= size / 2); ATF_REQUIRE((size_t)d.len >= size / 2 - sizeof(line)); - ATF_REQUIRE(d.atomizer_flags & DIFF_ATOMIZER_FILE_TRUNCATED); } ATF_TC_CLEANUP(diff_atomize_truncated, tc) { diff --git a/usr.bin/diff/diffreg_new.c b/usr.bin/diff/diffreg_new.c index d932764bb6da..f29e4ad8b9ed 100644 --- a/usr.bin/diff/diffreg_new.c +++ b/usr.bin/diff/diffreg_new.c @@ -223,14 +223,10 @@ diffreg_new(char *file1, char *file2, int flags, int capsicum) rc = D_ERROR; goto done; } - if (left.atomizer_flags & DIFF_ATOMIZER_FILE_TRUNCATED) - warnx("%s truncated", file1); if (diff_atomize_file(&right, cfg, f2, (uint8_t *)str2, st2.st_size, diff_flags)) { rc = D_ERROR; goto done; } - if (right.atomizer_flags & DIFF_ATOMIZER_FILE_TRUNCATED) - warnx("%s truncated", file2); result = diff_main(cfg, &left, &right); if (result->rc != DIFF_RC_OK) {