From owner-cvs-src@FreeBSD.ORG  Sat Jul 26 01:09:56 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A8F0E37B405
	for <cvs-src@FreeBSD.org>; Sat, 26 Jul 2003 01:09:56 -0700 (PDT)
Received: from mail26d.sbc-webhosting.com (mail26d.sbc-webhosting.com
	[216.173.237.167])
	by mx1.FreeBSD.org (Postfix) with SMTP id D79B943FBD
	for <cvs-src@FreeBSD.org>; Sat, 26 Jul 2003 01:09:54 -0700 (PDT)
	(envelope-from alc@imimic.com)
Received: from www.imimic.com (64.143.12.21)3-088096978;
	Sat, 26 Jul 2003 04:09:38 -0400 (EDT)
Sender: alc@FreeBSD.ORG
Message-ID: <3F223742.48F28685@imimic.com>
Date: Sat, 26 Jul 2003 03:09:38 -0500
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Peter Wemm <peter@wemm.org>
References: <20030726051002.37B3C2A7EA@canning.wemm.org>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
X-Loop-Detect: 1
cc: Alan Cox <alc@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm uma_core.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jul 2003 08:09:57 -0000

Peter Wemm wrote:
> 
> Alan Cox wrote:
> >   Modified files:
> >     sys/vm               uma_core.c
> >   Log:
> >   Gulp ... call kmem_malloc() without Giant.
> 
> So, let me guess, now would be a great time to update the kernel on my
> desktop, right? :-)
> 

I sincerely hope that it doesn't turn out to be a bad time.  :-)

To everyone: There are two "failure modes" that I would anticipate if
something is wrong.  The first would be an assertion failure that Giant
isn't held somewhere.  This is no big deal.  The second would be
seemingly random kernel crashes, probably in the vm system, due to
corruption of a vm object or vm page queue.  This is worrisome.  It
means that I've missed some access to a vm object or the vm page "cache"
queues that requires synchronization.  Unfortunately, due to the use of
vm objects as a kind of page table page container in the various pmaps,
I haven't been able to add as many assertions as I would like.

Regards,
Alan