From owner-svn-src-head@FreeBSD.ORG Fri Sep 14 12:24:50 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 231B4106564A; Fri, 14 Sep 2012 12:24:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id EAE5B8FC0C; Fri, 14 Sep 2012 12:24:49 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4C700B983; Fri, 14 Sep 2012 08:24:49 -0400 (EDT) From: John Baldwin To: Konstantin Belousov Date: Fri, 14 Sep 2012 08:19:05 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> In-Reply-To: <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201209140819.06026.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 14 Sep 2012 08:24:49 -0400 (EDT) Cc: Attilio Rao , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2012 12:24:50 -0000 On Friday, September 14, 2012 12:20:31 am Konstantin Belousov wrote: > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: > > Author: attilio > > Date: Thu Sep 13 22:26:22 2012 > > New Revision: 240475 > > URL: http://svn.freebsd.org/changeset/base/240475 > > > > Log: > > Remove all the checks on curthread != NULL with the exception of some MD > > trap checks (eg. printtrap()). > > > > Generally this check is not needed anymore, as there is not a legitimate > > case where curthread != NULL, after pcpu 0 area has been properly > > initialized. > I do not disagree with the patch, but I do with this statement. > During the AP startup, there is indeed a window while curthread is NULL. > Unfortunately, trying to panic there is worse then not panic. Also during early BSP startup. On x86 very early faults actually result in a BTX fault rather than a panic since we run with BTX's IDT for a bit in locore, etc. -- John Baldwin