From owner-freebsd-current@FreeBSD.ORG Mon Feb 14 19:16:30 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id F11BD1065672; Mon, 14 Feb 2011 19:16:29 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: freebsd-current@FreeBSD.org Date: Mon, 14 Feb 2011 14:16:15 -0500 User-Agent: KMail/1.6.2 References: <4D594C54.5000801@protected-networks.net> <201102141340.56392.jkim@FreeBSD.org> In-Reply-To: <201102141340.56392.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102141416.18180.jkim@FreeBSD.org> Cc: Michael Butler , Matthew Fleming Subject: Re: acpi_resource bug? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2011 19:16:30 -0000 On Monday 14 February 2011 01:40 pm, Jung-uk Kim wrote: > On Monday 14 February 2011 10:37 am, Michael Butler wrote: > > On 02/14/11 10:29, Matthew Fleming wrote: > > >>> 1) should the length of the bcopy() be changed to either > > >>> respect res->Length or the actual length of the > > >>> ACPI_RESOURCE_DATA for the type? > > >> > > >> It should just use res->Length: > > > > > > Is there a guarantee that res->Length is <= > > > sizeof(ACPI_RESOURCE) ? > > > > I don't know if it's related or a different bug .. > > > > If I run 'acpidump -t', I get a core-dump and .. > > > > [ .. snip .. ] > > > > /* > > MCFG: Length=60, Revision=1, Checksum=74, > > OEMID=INTEL, OEM Table ID=CALISTGA, OEM > > Revision=0x6040000, Creator ID=LOHR, Creator Revision=0x5a > > > > Base Address=0x00000000e0000000 > > Segment Group=0x0000 > > Start Bus=0 > > End Bus=255 > > */ > > /* > > TCPA: Length=50, Revision=1, Checksum=153, > > OEMID=PTLTD, OEM Table ID=CALISTGA, OEM > > Revision=0x6040000, Creator ID= PTL, Creator Revision=0x1 > > Class 0 Base Address 0x0 Length 65536 > > > > -268370093 0xc3e200f053ff00f053ff00f054ff00f0de9100f0 > > [] > > No, I don't think it is not related. Our acpidump(8) has its own > table parser. A terrible typo, sorry. I meant it is not related and our TCPA table parser seems incomplete. Jung-uk Kim