From owner-freebsd-arch@FreeBSD.ORG Mon Mar 22 14:51:06 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9458E106567A; Mon, 22 Mar 2010 14:51:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 63DE78FC1F; Mon, 22 Mar 2010 14:51:06 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 17E9346B6C; Mon, 22 Mar 2010 10:51:06 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 282598A028; Mon, 22 Mar 2010 10:51:05 -0400 (EDT) From: John Baldwin To: Alexander Leidinger Date: Mon, 22 Mar 2010 09:41:10 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003100812.29749.jhb@freebsd.org> <20100322123408.16671ijbvmcyux80@webmail.leidinger.net> In-Reply-To: <20100322123408.16671ijbvmcyux80@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003220941.10525.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 22 Mar 2010 10:51:05 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: "Robert N. M. Watson" , freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review (was: Re: is dtrace usable?) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 14:51:06 -0000 On Monday 22 March 2010 7:34:08 am Alexander Leidinger wrote: > Redirecting from stable@ to arch@... > > Quoting John Baldwin (from Wed, 10 Mar 2010 08:12:29 -0500): > > > On Wednesday 10 March 2010 5:34:22 am Alexander Leidinger wrote: > >> Quoting "Robert N. M. Watson" (from Tue, 9 Mar > >> 2010 16:39:09 +0000): > >> > >> > > >> > On Mar 9, 2010, at 2:16 PM, Alexander Leidinger wrote: > >> > > >> >>> From this you can see that sys.mk is included and parsed before > > 'Makefile', > >> >>> so the WITH_CTF=yes is not set until after sys.mk has been parsed. > >> >> > >> >> I think we need to find a different solution for this. The need to > >> >> specify WITH_CTF at the command line is very error prone. :( > >> > > >> > You are neither the first person to have made this observation, nor > >> > the first person to have failed to propose a solution in the form of > >> > a patch :-). > > Ok, here is the proposal in form of a patch. :-) > http://www.leidinger.net/test/ctf.diff > > > Unfortunately the ctf stuff breaks static binaries. I think that if > > that were > > fixed we would simply enable it by default and be done. > > The patch is: > - enabling CTF stuff by default for the kernel > - allows to disable the CTF stuff for the kernel by defining NO_CTF > - *not* enabling the CTF stuff by default for libs and progs > (if someone tells me how to distinguish the build for static > stuff from dynamic stuff, I can have a look to enable it for > the dynamic case) > - allows to enable the CTF stuff for the userland by defining > WITH_CTF as before I think this patch looks very interesting. I think in some ways it would be nice to make CTF "opt-in" though instead of "opt-out". I think the current patch would enable CTF when building ports, for example. I think instead it should default to not building CTF, but require an ENABLE_CTF (instead of NO_CTF) to be set, and set that in bsd.kern.mk if WITH_CTF is defined. -- John Baldwin