Date: Sat, 28 Apr 2012 05:00:47 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r234748 - head/sys/dev/ath Message-ID: <201204280500.q3S50lcZ043074@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Sat Apr 28 05:00:47 2012 New Revision: 234748 URL: http://svn.freebsd.org/changeset/base/234748 Log: Add a comment about this DELAY(), I'm not sure whether it's supposed to be for a DDR/FIFO flush or something else. Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Sat Apr 28 03:07:36 2012 (r234747) +++ head/sys/dev/ath/if_ath.c Sat Apr 28 05:00:47 2012 (r234748) @@ -5417,6 +5417,10 @@ ath_stoprecv(struct ath_softc *sc, int d ath_hal_stoppcurecv(ah); /* disable PCU */ ath_hal_setrxfilter(ah, 0); /* clear recv filter */ ath_hal_stopdmarecv(ah); /* disable DMA engine */ + /* + * TODO: see if this particular DELAY() is required; it may be + * masking some missing FIFO flush or DMA sync. + */ if (dodelay) DELAY(3000); /* 3ms is long enough for 1 frame */ #ifdef ATH_DEBUG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204280500.q3S50lcZ043074>