From owner-svn-src-all@FreeBSD.ORG Sat Apr 28 05:00:48 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C933106564A; Sat, 28 Apr 2012 05:00:48 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 278D38FC0C; Sat, 28 Apr 2012 05:00:48 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q3S50mcQ043076; Sat, 28 Apr 2012 05:00:48 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q3S50lcZ043074; Sat, 28 Apr 2012 05:00:47 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201204280500.q3S50lcZ043074@svn.freebsd.org> From: Adrian Chadd Date: Sat, 28 Apr 2012 05:00:47 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r234748 - head/sys/dev/ath X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Apr 2012 05:00:48 -0000 Author: adrian Date: Sat Apr 28 05:00:47 2012 New Revision: 234748 URL: http://svn.freebsd.org/changeset/base/234748 Log: Add a comment about this DELAY(), I'm not sure whether it's supposed to be for a DDR/FIFO flush or something else. Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Sat Apr 28 03:07:36 2012 (r234747) +++ head/sys/dev/ath/if_ath.c Sat Apr 28 05:00:47 2012 (r234748) @@ -5417,6 +5417,10 @@ ath_stoprecv(struct ath_softc *sc, int d ath_hal_stoppcurecv(ah); /* disable PCU */ ath_hal_setrxfilter(ah, 0); /* clear recv filter */ ath_hal_stopdmarecv(ah); /* disable DMA engine */ + /* + * TODO: see if this particular DELAY() is required; it may be + * masking some missing FIFO flush or DMA sync. + */ if (dodelay) DELAY(3000); /* 3ms is long enough for 1 frame */ #ifdef ATH_DEBUG