From owner-svn-src-head@FreeBSD.ORG Wed Jul 10 23:58:32 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1CB40D26; Wed, 10 Jul 2013 23:58:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-vc0-x22c.google.com (mail-vc0-x22c.google.com [IPv6:2607:f8b0:400c:c03::22c]) by mx1.freebsd.org (Postfix) with ESMTP id 9C63F11EE; Wed, 10 Jul 2013 23:58:31 +0000 (UTC) Received: by mail-vc0-f172.google.com with SMTP id ib11so6284442vcb.17 for ; Wed, 10 Jul 2013 16:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wI3mFey19Fy5XfGWqSow00VGAfxqzds6kz9qYHcbi8E=; b=LafCbKhAxuaZ1YitfPn0ZmszHeICGL4A6SupSEDR6MYLfT2v+RS2dnx8qQ9CqyeuKc qzTe03ISJgrDsPMXT1+zD9ZSJumJ9XD8Qobc/N9q0BIPpZ5wQJtzJp2Mo9yhZsDP5S6m Ful3AL0UtD4alSUX8qFjLC9bqzX4/MGGdoNUHJi/G51ETBCxnoZTjANF3T5b3HvelmlW UFmTkJqAq7clyxwricy7h2iKLNQAcPb/eQiLbE9AzkZLgnjEV0K0iUWFdRIYaEXuAJUv Kr6kWDjzvIy0ApMBycBwSROfsCYp/kIACqHV2rcOfsNvy121ZgDY1Sv1gPg5YNy4wFrk 1ieA== MIME-Version: 1.0 X-Received: by 10.52.16.77 with SMTP id e13mr17027131vdd.49.1373500710573; Wed, 10 Jul 2013 16:58:30 -0700 (PDT) Received: by 10.220.146.145 with HTTP; Wed, 10 Jul 2013 16:58:30 -0700 (PDT) In-Reply-To: <201307091120.22114.jhb@freebsd.org> References: <201307082125.r68LPDlY023493@svn.freebsd.org> <3FF894D3-ACDF-4796-A682-F9F9DD8C943D@gmail.com> <201307091120.22114.jhb@freebsd.org> Date: Wed, 10 Jul 2013 16:58:30 -0700 Message-ID: Subject: Re: svn commit: r253048 - in head/sys/ofed: drivers/net/mlx4 include/linux From: Garrett Cooper To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head , svn-src-all , src-committers , shahark@mellanox.com, acornehl@gmail.com X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jul 2013 23:58:32 -0000 On Tue, Jul 9, 2013 at 8:20 AM, John Baldwin wrote: ... > I hadn't seen it. I had wondered if the '\n' issue was a generic sysfs thing. > It sounds like it is and I'd be happy to revert the mlx4 change and alter the > sysfs bits to manage the newline directly if that is more appropriate. I'll doublecheck this, but basically I'm really adverse to diverging from Linux in this area -- hence that's why I did what I did in the PR I mentioned. > I'd also like this to use sysctl_handle_string() if at all possible. Are you in > a position to test patches still? Unfortunately I'm not right now :(. Anthony may or may not be able to test this out (I used his machine when we were hacking around on IB stuff). > If so, maybe give this a whirl. It's similar to yours except it uses > sysctl_handle_string() and strlcat() rather than continuing to do things > by hand. It also outputs an empty string to userland if the attribute > doesn't have a show method (your version would never pass out an old > string in that case unlike the original code). Can you please pass along a patch to Anthony and me so we can try and apply it to test it out (Gmail's going to taint the inline patch, as is the EMC Exchange server with the patch attachment)? If Anthony still has the machine setup, then I'd be more than happy to test out the patch :). Thanks!