Date: Wed, 18 Jul 2012 03:19:44 +0300 From: Alex Kozlov <spam@rm-rf.kiev.ua> To: Doug Barton <dougb@dougbarton.us>, Niclas Zeising <zeising@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301039 - head/archivers/zlib Message-ID: <20120718001944.GA71608@ravenloft.kiev.ua> In-Reply-To: <5005FDBD.5000407@dougbarton.us> References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org> <20120717230739.GA66332@ravenloft.kiev.ua> <5005F1E3.7080606@dougbarton.us> <20120717234412.GA69885@ravenloft.kiev.ua> <5005FDBD.5000407@dougbarton.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 17, 2012 at 05:05:17PM -0700, Doug Barton wrote: > On 07/17/2012 04:44 PM, Alex Kozlov wrote: > > On Tue, Jul 17, 2012 at 04:14:43PM -0700, Doug Barton wrote: > >> On 07/17/2012 04:07 PM, Alex Kozlov wrote: > >>> On Wed, Jul 18, 2012 at 12:23:00AM +0200, Niclas Zeising wrote: > >>>> On 07/17/12 23:38, Doug Barton wrote: > >>>>> Was this causing you some sort of specific problem? AFAIK this happens > >>>>> often, possibly as a result of 'make makesum'. "Fixing" this everyplace > >>>>> that it occurs would almost certainly cause a lot of needless churn. > >>> Actually, it's pretty rare occurrence, > >> Maybe I'm just lucky then, because I see it all the time. > > There were 7 cases in the last 3 months plus 2 pending: > > ports/audio/pianobar/distinfo: missing SIZE for pianobar-2012.06.24.tar.bz2 > > ports/mail/meta1/distinfo: missing SIZE for meta1-1.0.Alpha11.0.tar.gz > > Missing the SIZE line altogether is a totally different thing than a > missing newline. And both of those files have the SIZE line. > > > It works because sh assume EOF == EOL, it's would fall in more strict parser. > My first question to zi was, "Are you seeing any specific problems > caused by this?" If you can answer that question with real, specific > information then we can talk about that. If your concern is that it > *might* cause unknown problems with some unknown thing at some unknown > time in the future then I restate my original thesis: We have bigger > things to worry about, and this change isn't worth the repo churn. Those two lines above are not only list of distinfo files with absent EOL at the last line, but also an example of real parser which broken by such distinfo. -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120718001944.GA71608>