Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 May 1997 17:44:52 -0700 (PDT)
From:      Archie Cobbs <archie@whistle.com>
To:        avalon@coombs.anu.edu.au (Darren Reed)
Cc:        nnd@info.itfs.nsk.su, current@freebsd.org, hackers@freebsd.org
Subject:   Re: divert still broken?
Message-ID:  <199705060044.RAA10251@bubba.whistle.com>
In-Reply-To: <199705060032.RAA16250@gatekeeper.whistle.com> from Darren Reed at "May 6, 97 10:30:29 am"

next in thread | previous in thread | raw e-mail | index | archive | help

> >  - Simplify the ip_fw_chk() function call interface
> 
> well, the list of things which you must pass are:
> * pointer to a pointer to an mbuf (ip_fw_chk() may want to modify it - e.g.
> 	  calls m_pullup)

Keeping this...

> * interface (m_rcvif is often NULL in ip_output, besides which setting it
> 	     in ip_output is semantically incorrect)
> * value indicating whether it is being called from ip_input or ip_output

Changing this.. m_rcvif is NULL if-and-only-if there is no receive
interface associated with the packet. Also, you'll noticed that
the call from ip_input() just sets this parameter to m_rcvif from
the packet. So these two arguments are being replaced by a single
argument with is the output interface... which is NULL if-and-only-if
the direction of the packet is incoming.

> - that's the *must have* list.  Convienience parameters are:
> * pointer to the IP header
> * precomputed real IP header length (from ip_hl)

Keeping...

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705060044.RAA10251>