From owner-freebsd-current  Mon May  5 17:45:26 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id RAA01888
          for current-outgoing; Mon, 5 May 1997 17:45:26 -0700 (PDT)
Received: from whistle.com (s205m131.whistle.com [207.76.205.131])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id RAA01883;
          Mon, 5 May 1997 17:45:24 -0700 (PDT)
Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id RAA18238; Mon, 5 May 1997 17:44:53 -0700 (PDT)
Received: from bubba.whistle.com(207.76.205.7) by whistle.com via smap (V1.3)
	id sma018236; Mon May  5 17:44:53 1997
Received: (from archie@localhost) by bubba.whistle.com (8.7.5/8.6.12) id RAA10251; Mon, 5 May 1997 17:44:52 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199705060044.RAA10251@bubba.whistle.com>
Subject: Re: divert still broken?
In-Reply-To: <199705060032.RAA16250@gatekeeper.whistle.com> from Darren Reed at "May 6, 97 10:30:29 am"
To: avalon@coombs.anu.edu.au (Darren Reed)
Date: Mon, 5 May 1997 17:44:52 -0700 (PDT)
Cc: nnd@info.itfs.nsk.su, current@freebsd.org, hackers@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL25 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


> >  - Simplify the ip_fw_chk() function call interface
> 
> well, the list of things which you must pass are:
> * pointer to a pointer to an mbuf (ip_fw_chk() may want to modify it - e.g.
> 	  calls m_pullup)

Keeping this...

> * interface (m_rcvif is often NULL in ip_output, besides which setting it
> 	     in ip_output is semantically incorrect)
> * value indicating whether it is being called from ip_input or ip_output

Changing this.. m_rcvif is NULL if-and-only-if there is no receive
interface associated with the packet. Also, you'll noticed that
the call from ip_input() just sets this parameter to m_rcvif from
the packet. So these two arguments are being replaced by a single
argument with is the output interface... which is NULL if-and-only-if
the direction of the packet is incoming.

> - that's the *must have* list.  Convienience parameters are:
> * pointer to the IP header
> * precomputed real IP header length (from ip_hl)

Keeping...

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com